Re: [PATCH] PCI: dwc: fix error return code in dw_pcie_host_init()

2020-11-16 Thread wanghai (M)
ret = -ENOMEM; what about use the return value of dma_maping_error()? I.E ret = dma_mapping_error() if (ret) { } Thanks for your review,  I just sent v2 "[PATCH v2] PCI: dwc: fix error return code in dw_pcie_host_init()" .

Re: [PATCH] PCI: dwc: fix error return code in dw_pcie_host_init()

2020-11-16 Thread Jisheng Zhang
On Mon, 16 Nov 2020 21:50:23 +0800 Wang Hai wrote: > > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. good catch. > > Fixes: 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume") > Reported-by: Hulk Robot >

[PATCH] PCI: dwc: fix error return code in dw_pcie_host_init()

2020-11-16 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/pci/controller/dwc/pcie-designware-host.c | 1