Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-14 Thread Alex_Gagniuc
On 2/14/19 1:01 AM, Lukas Wunner wrote: > On Wed, Feb 13, 2019 at 06:55:46PM +, alex_gagn...@dellteam.com wrote: >> On 2/13/19 2:36 AM, Lukas Wunner wrote: (*) A bit hypothetical: There is no hardware yet implementing the ECN. >>> >>> Hm, this contradicts Austin Bolen's e-mail of Jan 25 th

Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-13 Thread Lukas Wunner
On Wed, Feb 13, 2019 at 06:55:46PM +, alex_gagn...@dellteam.com wrote: > On 2/13/19 2:36 AM, Lukas Wunner wrote: > > > (*) A bit hypothetical: There is no hardware yet implementing the ECN. > > > > Hm, this contradicts Austin Bolen's e-mail of Jan 25 that "Yes, this > > platform disables in-ba

Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-13 Thread Alex_Gagniuc
On 2/13/19 2:36 AM, Lukas Wunner wrote: >> (*) A bit hypothetical: There is no hardware yet implementing the ECN. > > Hm, this contradicts Austin Bolen's e-mail of Jan 25 that "Yes, this > platform disables in-band presence" (when asked whether your host > controller already adheres to the ECN).

Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-13 Thread Lukas Wunner
On Tue, Feb 12, 2019 at 11:57:55PM +, alex_gagn...@dellteam.com wrote: > The recommendation is to set the "in-band PD disable" bit, and it's > possible that platform firmware may have set it at boot time Ok, then I'd suggest to check in pcie_init() whether the feature is supported and enable i

Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-12 Thread Alex_Gagniuc
On 2/12/19 2:30 AM, Lukas Wunner wrote: > The PCI SIG > should probably consider granting access to specs to open source > developers to ease adoption of new features in Linux et al. Don't get me started on just how ridiculous I think PCI-SIG's policy is with respect to public availability of sta

Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-12 Thread Lukas Wunner
On Tue, Feb 12, 2019 at 09:30:31AM +0100, Lukas Wunner wrote: > Instead of modifying the logic in pciehp_handle_presence_or_link_change(), > you could amend pcie_wait_for_link() to poll PDS until it's set, in > addition to DLLLA. The rationale would be that although the link is up, > the hot-added

Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-12 Thread Lukas Wunner
On Mon, Feb 11, 2019 at 11:48:12PM +, alex_gagn...@dellteam.com wrote: > On 2/9/19 5:58 AM, Lukas Wunner wrote: > ECN [1] was approved last November, so it's normative spec text. Sorry > if the Ukranians didn't get ahold of it yet. I'll try to explain the delta. > There's an in-band PD support

Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-11 Thread Alex_Gagniuc
On 2/9/19 5:58 AM, Lukas Wunner wrote: > > [EXTERNAL EMAIL] > > On Tue, Feb 05, 2019 at 03:06:56PM -0600, Alexandru Gagniuc wrote: >> According to PCIe 3.0, the presence detect state is a logical OR of >> in-band and out-of-band presence. > > Since Bjorn asked for a spec reference: > > PCIe r4.

Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-09 Thread Lukas Wunner
On Tue, Feb 05, 2019 at 03:06:56PM -0600, Alexandru Gagniuc wrote: > According to PCIe 3.0, the presence detect state is a logical OR of > in-band and out-of-band presence. Since Bjorn asked for a spec reference: PCIe r4.0 sec 7.8.11: "Presence Detect State - This bit indicates the presence of an

Re: [PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-08 Thread Bjorn Helgaas
On Tue, Feb 05, 2019 at 03:06:56PM -0600, Alexandru Gagniuc wrote: > According to PCIe 3.0, the presence detect state is a logical OR of > in-band and out-of-band presence. With this, we'd expect the presence > state to always be asserted when the link comes up. Do you have a PCIe 4.0 spec? I thi

[PATCH] PCI: pciehp: Do not turn off slot if presence comes up after link

2019-02-05 Thread Alexandru Gagniuc
According to PCIe 3.0, the presence detect state is a logical OR of in-band and out-of-band presence. With this, we'd expect the presence state to always be asserted when the link comes up. Not all hardware follows this, and it is possible for the presence to come up after the link. In this case,