[PATCH] PCI: xgene: fix a mistake about cfg address

2021-03-28 Thread Dejin Zheng
It has a wrong modification to the xgene driver by the commit e2dcd20b1645a. it use devm_platform_ioremap_resource_byname() to simplify codes and remove the res variable, But the following code needs to use this res variable, So after this commit, the port->cfg_addr will get a wrong address. Now, r

Re: [PATCH] PCI: xgene: fix a mistake about cfg address

2021-03-29 Thread Lorenzo Pieralisi
On Sun, 28 Mar 2021 22:41:18 +0800, Dejin Zheng wrote: > It has a wrong modification to the xgene driver by the commit > e2dcd20b1645a. it use devm_platform_ioremap_resource_byname() to > simplify codes and remove the res variable, But the following code > needs to use this res variable, So after t

Re: [PATCH] PCI: xgene: fix a mistake about cfg address

2021-03-30 Thread Bjorn Helgaas
On Sun, Mar 28, 2021 at 10:41:18PM +0800, Dejin Zheng wrote: > It has a wrong modification to the xgene driver by the commit > e2dcd20b1645a. it use devm_platform_ioremap_resource_byname() to > simplify codes and remove the res variable, But the following code > needs to use this res variable, So a

Re: [PATCH] PCI: xgene: fix a mistake about cfg address

2021-03-31 Thread Lorenzo Pieralisi
On Tue, Mar 30, 2021 at 02:19:26PM -0500, Bjorn Helgaas wrote: > On Sun, Mar 28, 2021 at 10:41:18PM +0800, Dejin Zheng wrote: > > It has a wrong modification to the xgene driver by the commit > > e2dcd20b1645a. it use devm_platform_ioremap_resource_byname() to > > simplify codes and remove the res

Re: [PATCH] PCI: xgene: fix a mistake about cfg address

2021-03-28 Thread dann frazier
On Sun, Mar 28, 2021 at 10:41:18PM +0800, Dejin Zheng wrote: > It has a wrong modification to the xgene driver by the commit > e2dcd20b1645a. it use devm_platform_ioremap_resource_byname() to > simplify codes and remove the res variable, But the following code > needs to use this res variable, So a