Re: [PATCH] PCI-iproc: Delete unnecessary checks before two function calls

2015-07-14 Thread Ray Jui
On 7/14/2015 1:51 PM, Bjorn Helgaas wrote: > On Tue, Jul 14, 2015 at 01:23:23PM -0700, Ray Jui wrote: >> Hi Bjorn, >> >> On 7/14/2015 1:10 PM, Bjorn Helgaas wrote: >>> On Sun, Jun 28, 2015 at 04:52:16PM +0200, SF Markus Elfring wrote: From: Markus Elfring Date: Sun, 28 Jun 2015 16:42:0

Re: [PATCH] PCI-iproc: Delete unnecessary checks before two function calls

2015-07-14 Thread Bjorn Helgaas
On Tue, Jul 14, 2015 at 01:23:23PM -0700, Ray Jui wrote: > Hi Bjorn, > > On 7/14/2015 1:10 PM, Bjorn Helgaas wrote: > > On Sun, Jun 28, 2015 at 04:52:16PM +0200, SF Markus Elfring wrote: > >> From: Markus Elfring > >> Date: Sun, 28 Jun 2015 16:42:04 +0200 > >> > >> The functions phy_exit() and ph

Re: [PATCH] PCI-iproc: Delete unnecessary checks before two function calls

2015-07-14 Thread Ray Jui
Hi Bjorn, On 7/14/2015 1:10 PM, Bjorn Helgaas wrote: > On Sun, Jun 28, 2015 at 04:52:16PM +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Sun, 28 Jun 2015 16:42:04 +0200 >> >> The functions phy_exit() and phy_power_off() test whether their argument >> is NULL and then return imme

Re: [PATCH] PCI-iproc: Delete unnecessary checks before two function calls

2015-07-14 Thread Bjorn Helgaas
On Sun, Jun 28, 2015 at 04:52:16PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 28 Jun 2015 16:42:04 +0200 > > The functions phy_exit() and phy_power_off() test whether their argument > is NULL and then return immediately. > Thus the test around the calls is not needed. >

Re: [PATCH] PCI-iproc: Delete unnecessary checks before two function calls

2015-06-29 Thread Ray Jui
Hi Markus, On 6/28/2015 7:52 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 28 Jun 2015 16:42:04 +0200 > > The functions phy_exit() and phy_power_off() test whether their argument > is NULL and then return immediately. > Thus the test around the calls is not needed. > > This i

[PATCH] PCI-iproc: Delete unnecessary checks before two function calls

2015-06-28 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 28 Jun 2015 16:42:04 +0200 The functions phy_exit() and phy_power_off() test whether their argument is NULL and then return immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus