Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-09-02 Thread Kai-Heng Feng
at 21:45, Bjorn Helgaas wrote: On Fri, Jul 05, 2019 at 03:02:01PM +0800, Kai-Heng Feng wrote: at 19:57, Bjorn Helgaas wrote: On Mon, May 27, 2019 at 11:57:47AM -0500, Bjorn Helgaas wrote: I'm wondering if this platform has a firmware defect. Here's my thinking. The xHC is a Root Complex

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-07-09 Thread Bjorn Helgaas
On Fri, Jul 05, 2019 at 03:02:01PM +0800, Kai-Heng Feng wrote: > at 19:57, Bjorn Helgaas wrote: > > On Mon, May 27, 2019 at 11:57:47AM -0500, Bjorn Helgaas wrote: > > > I'm wondering if this platform has a firmware defect. Here's my > > > thinking. The xHC is a Root Complex Integrated Endpoint,

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-07-05 Thread Kai-Heng Feng
at 17:39, Rafael J. Wysocki wrote: On Friday, July 5, 2019 9:02:01 AM CEST Kai-Heng Feng wrote: at 19:57, Bjorn Helgaas wrote: On Mon, May 27, 2019 at 11:57:47AM -0500, Bjorn Helgaas wrote: On Thu, May 23, 2019 at 12:39:23PM +0800, Kai-Heng Feng wrote: at 04:52, Bjorn Helgaas wrote: On

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-07-05 Thread Rafael J. Wysocki
On Friday, July 5, 2019 9:02:01 AM CEST Kai-Heng Feng wrote: > at 19:57, Bjorn Helgaas wrote: > > > On Mon, May 27, 2019 at 11:57:47AM -0500, Bjorn Helgaas wrote: > >> On Thu, May 23, 2019 at 12:39:23PM +0800, Kai-Heng Feng wrote: > >>> at 04:52, Bjorn Helgaas wrote: > On Wed, May 22, 2019

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-07-05 Thread Kai-Heng Feng
at 19:57, Bjorn Helgaas wrote: On Mon, May 27, 2019 at 11:57:47AM -0500, Bjorn Helgaas wrote: On Thu, May 23, 2019 at 12:39:23PM +0800, Kai-Heng Feng wrote: at 04:52, Bjorn Helgaas wrote: On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: On Wed, 22 May 2019, Bjorn Helgaas wrote:

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-06-05 Thread Bjorn Helgaas
On Mon, May 27, 2019 at 11:57:47AM -0500, Bjorn Helgaas wrote: > On Thu, May 23, 2019 at 12:39:23PM +0800, Kai-Heng Feng wrote: > > at 04:52, Bjorn Helgaas wrote: > > > On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: > > > > On Wed, 22 May 2019, Bjorn Helgaas wrote: > > > > > On Wed, M

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-27 Thread Bjorn Helgaas
On Thu, May 23, 2019 at 12:39:23PM +0800, Kai-Heng Feng wrote: > at 04:52, Bjorn Helgaas wrote: > > On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: > > > On Wed, 22 May 2019, Bjorn Helgaas wrote: > > > > On Wed, May 22, 2019 at 11:46:25PM +0800, Kai Heng Feng wrote: > > > > > > On May

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-22 Thread Kai-Heng Feng
at 04:52, Bjorn Helgaas wrote: On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: On Wed, 22 May 2019, Bjorn Helgaas wrote: On Wed, May 22, 2019 at 11:46:25PM +0800, Kai Heng Feng wrote: On May 22, 2019, at 9:48 PM, Bjorn Helgaas wrote: On Wed, May 22, 2019 at 11:42:14AM +0800, Kai

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-22 Thread Bjorn Helgaas
On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: > On Wed, 22 May 2019, Bjorn Helgaas wrote: > > On Wed, May 22, 2019 at 11:46:25PM +0800, Kai Heng Feng wrote: > > > > On May 22, 2019, at 9:48 PM, Bjorn Helgaas wrote: > > > > On Wed, May 22, 2019 at 11:42:14AM +0800, Kai Heng Feng wrote

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-22 Thread Kai Heng Feng
> On May 23, 2019, at 2:53 AM, Lukas Wunner wrote: > > On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: >> According to Kai, PME signalling doesn't work in D0 -- or at least, it >> is _documented_ not to work in D0 -- even though it is enabled and the >> device claims to support it.

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-22 Thread Lukas Wunner
On Wed, May 22, 2019 at 02:39:56PM -0400, Alan Stern wrote: > According to Kai, PME signalling doesn't work in D0 -- or at least, it > is _documented_ not to work in D0 -- even though it is enabled and the > device claims to support it. > > In any case, I don't really see any point in "runtime sus

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-22 Thread Alan Stern
On Wed, 22 May 2019, Bjorn Helgaas wrote: > On Wed, May 22, 2019 at 11:46:25PM +0800, Kai Heng Feng wrote: > > > On May 22, 2019, at 9:48 PM, Bjorn Helgaas wrote: > > > On Wed, May 22, 2019 at 11:42:14AM +0800, Kai Heng Feng wrote: > > >> at 6:23 AM, Bjorn Helgaas wrote: > > >>> On Wed, May 22,

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-22 Thread Bjorn Helgaas
On Wed, May 22, 2019 at 11:46:25PM +0800, Kai Heng Feng wrote: > > On May 22, 2019, at 9:48 PM, Bjorn Helgaas wrote: > > On Wed, May 22, 2019 at 11:42:14AM +0800, Kai Heng Feng wrote: > >> at 6:23 AM, Bjorn Helgaas wrote: > >>> On Wed, May 22, 2019 at 12:31:04AM +0800, Kai-Heng Feng wrote: >

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-22 Thread Kai Heng Feng
> On May 22, 2019, at 9:48 PM, Bjorn Helgaas wrote: > > On Wed, May 22, 2019 at 11:42:14AM +0800, Kai Heng Feng wrote: >> at 6:23 AM, Bjorn Helgaas wrote: >>> On Wed, May 22, 2019 at 12:31:04AM +0800, Kai-Heng Feng wrote: There's an xHC device that doesn't wake when a USB device gets plu

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-22 Thread Bjorn Helgaas
On Wed, May 22, 2019 at 11:42:14AM +0800, Kai Heng Feng wrote: > at 6:23 AM, Bjorn Helgaas wrote: > > On Wed, May 22, 2019 at 12:31:04AM +0800, Kai-Heng Feng wrote: > > > There's an xHC device that doesn't wake when a USB device gets plugged > > > to its USB port. The driver's own runtime suspend

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-21 Thread Kai Heng Feng
at 6:23 AM, Bjorn Helgaas wrote: [+cc Mathias, linux-usb] On Wed, May 22, 2019 at 12:31:04AM +0800, Kai-Heng Feng wrote: There's an xHC device that doesn't wake when a USB device gets plugged to its USB port. The driver's own runtime suspend callback was called, PME signaling was enabled, but

Re: [PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-21 Thread Bjorn Helgaas
[+cc Mathias, linux-usb] On Wed, May 22, 2019 at 12:31:04AM +0800, Kai-Heng Feng wrote: > There's an xHC device that doesn't wake when a USB device gets plugged > to its USB port. The driver's own runtime suspend callback was called, > PME signaling was enabled, but it stays at PCI D0. s/xHC/xHCI

[PATCH] PCI / PM: Don't runtime suspend when device only supports wakeup from D0

2019-05-21 Thread Kai-Heng Feng
There's an xHC device that doesn't wake when a USB device gets plugged to its USB port. The driver's own runtime suspend callback was called, PME signaling was enabled, but it stays at PCI D0. A PCI device can be runtime suspended to D0 when it supports D0 PME and its _S0W reports D0. Theoraticall