Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Rafael J. Wysocki
On Monday, August 24, 2020 5:04:21 PM CEST Alan Stern wrote: > On Mon, Aug 24, 2020 at 03:36:36PM +0200, Rafael J. Wysocki wrote: > > > Furthermore, by the logic used in this patch, the call to > > > pm_wakeup_event() in the original code is also redundant: Any required > > > wakeup event should

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Alan Stern
On Mon, Aug 24, 2020 at 03:36:36PM +0200, Rafael J. Wysocki wrote: > > Furthermore, by the logic used in this patch, the call to > > pm_wakeup_event() in the original code is also redundant: Any required > > wakeup event should have been generated when the runtime resume inside > > pm_runtime_ba

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Mika Westerberg
On Mon, Aug 24, 2020 at 03:38:39PM +0200, Rafael J. Wysocki wrote: > BTW, does the patch make the issue at hand go away? I asked the folks who have this particular hardware to try it out as I don't have access to this one. Hopefully we get the results back soon and once we do, I'll let you know.

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Rafael J. Wysocki
On Friday, August 21, 2020 9:34:42 PM CEST Alan Stern wrote: > On Fri, Aug 21, 2020 at 07:41:02PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > It has been reported that system-wide suspend may be aborted in the > > absence of any wakeup events due to unforseen interactions

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Rafael J. Wysocki
On Monday, August 24, 2020 10:34:52 AM CEST Mika Westerberg wrote: > Hi, > > On Fri, Aug 21, 2020 at 03:34:42PM -0400, Alan Stern wrote: > > This means that the code could be simplified to just: > > > > pm_runtime_barrier(dev); > > > > Will this fix the reported bug? It seems likely to me t

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-24 Thread Mika Westerberg
Hi, On Fri, Aug 21, 2020 at 03:34:42PM -0400, Alan Stern wrote: > This means that the code could be simplified to just: > > pm_runtime_barrier(dev); > > Will this fix the reported bug? It seems likely to me that the actual > problem with the failure scenario in the patch description was

Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-21 Thread Alan Stern
On Fri, Aug 21, 2020 at 07:41:02PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > It has been reported that system-wide suspend may be aborted in the > absence of any wakeup events due to unforseen interactions of it with > the runtume PM framework. > > One failing scenario is whe

[PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests

2020-08-21 Thread Rafael J. Wysocki
From: Rafael J. Wysocki It has been reported that system-wide suspend may be aborted in the absence of any wakeup events due to unforseen interactions of it with the runtume PM framework. One failing scenario is when there are multiple devices sharing an ACPI power resource and runtime-resume ne