Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-15 Thread Viresh Kumar
On 15-10-15, 23:26, Rafael J. Wysocki wrote: > Well, to be honest, I would prefer a replacement. Ahh, I thought you will suggest a separate patch so that you don't need to rebase your tree. But I don't have any issues with a new version of the patch. -- viresh -- To unsubscribe from this list: s

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-15 Thread Rafael J. Wysocki
On Thursday, October 15, 2015 08:07:38 PM Viresh Kumar wrote: > On 15-10-15, 09:42, Thomas Petazzoni wrote: > > Do you want me to resend a new version? Or a follow-up patch based on > > the latest tree from Rafael now that he has applied the previous version? > > A follow up patch, without any Fix

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-15 Thread Viresh Kumar
On 15-10-15, 09:42, Thomas Petazzoni wrote: > Do you want me to resend a new version? Or a follow-up patch based on > the latest tree from Rafael now that he has applied the previous version? A follow up patch, without any Fixes tag would be fine. -- viresh -- To unsubscribe from this list: send

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-15 Thread Thomas Petazzoni
Viresh, Rafael, On Thu, 15 Oct 2015 13:05:44 +0530, Viresh Kumar wrote: > On 14-10-15, 17:52, Thomas Petazzoni wrote: > > ret = of_init_opp_table(cpu_dev); > > if (ret) { > > - pr_err("%s: couldn't find opp table for cpu:%d, %d\n", > > -

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-15 Thread Viresh Kumar
On 14-10-15, 17:52, Thomas Petazzoni wrote: > ret = of_init_opp_table(cpu_dev); > if (ret) { > - pr_err("%s: couldn't find opp table for cpu:%d, %d\n", > -__func__, cpu, ret); > - It should have be modified to pr_debug() a

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-14 Thread Rafael J. Wysocki
On Wednesday, October 14, 2015 11:29:27 PM Thomas Petazzoni wrote: > Hello, > > On Wed, 14 Oct 2015 23:44:03 +0200, Rafael J. Wysocki wrote: > > On Wednesday, October 14, 2015 11:10:39 PM Thomas Petazzoni wrote: > > > Rafael, > > > > > > On Wed, 14 Oct 2015 23:28:51 +0200, Rafael J. Wysocki wrote

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-14 Thread Thomas Petazzoni
Rafael, On Wed, 14 Oct 2015 23:59:45 +0200, Rafael J. Wysocki wrote: > > Yes, I wasn't sure if it really is a fix, and if so, which commit it is > > fixing. It is really 8d4d4e98acd68c31435ebb7beea591dbf60b9eb2 that > > introduces the confusing message, but the message will not appear until > > t

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-14 Thread Thomas Petazzoni
Hello, On Wed, 14 Oct 2015 23:44:03 +0200, Rafael J. Wysocki wrote: > On Wednesday, October 14, 2015 11:10:39 PM Thomas Petazzoni wrote: > > Rafael, > > > > On Wed, 14 Oct 2015 23:28:51 +0200, Rafael J. Wysocki wrote: > > > > > > To avoid this confusion, this patch simply deletes the error messa

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-14 Thread Rafael J. Wysocki
On Wednesday, October 14, 2015 11:10:39 PM Thomas Petazzoni wrote: > Rafael, > > On Wed, 14 Oct 2015 23:28:51 +0200, Rafael J. Wysocki wrote: > > > > To avoid this confusion, this patch simply deletes the error message. > > > > > > Signed-off-by: Thomas Petazzoni > > > > That's only present in

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-14 Thread Thomas Petazzoni
Rafael, On Wed, 14 Oct 2015 23:28:51 +0200, Rafael J. Wysocki wrote: > > To avoid this confusion, this patch simply deletes the error message. > > > > Signed-off-by: Thomas Petazzoni > > That's only present in linux-next now, right? No, it is already in 4.3-rc since 4.3-rc1. The commit adding

Re: [PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-14 Thread Rafael J. Wysocki
On Wednesday, October 14, 2015 05:52:23 PM Thomas Petazzoni wrote: > The of_cpumask_init_opp_table() function will print an error message > (with pr_err) if it cannot find the OPP table for a certain CPU in the > Device Tree. > > There are users of the cpufreq-dt driver (which is the one calling >

[PATCH] PM / OPP: Remove confusing error message in of_cpumask_init_opp_table()

2015-10-14 Thread Thomas Petazzoni
The of_cpumask_init_opp_table() function will print an error message (with pr_err) if it cannot find the OPP table for a certain CPU in the Device Tree. There are users of the cpufreq-dt driver (which is the one calling of_cpumask_init_opp_table) that do not have the OPP points defined in the Devi