Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-17 Thread Rafael J. Wysocki
On Saturday, May 16, 2015 11:37:01 PM Geert Uytterhoeven wrote: > On Thu, May 14, 2015 at 12:45 AM, Rafael J. Wysocki > wrote: > > On Tuesday, May 12, 2015 05:32:29 PM Dmitry Torokhov wrote: > >> On Wed, May 13, 2015 at 02:22:50AM +0200, Rafael J. Wysocki wrote: > >> > On Tuesday, May 12, 2015 11

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-16 Thread Geert Uytterhoeven
On Thu, May 14, 2015 at 12:45 AM, Rafael J. Wysocki wrote: > On Tuesday, May 12, 2015 05:32:29 PM Dmitry Torokhov wrote: >> On Wed, May 13, 2015 at 02:22:50AM +0200, Rafael J. Wysocki wrote: >> > On Tuesday, May 12, 2015 11:07:33 AM Dmitry Torokhov wrote: >> > > On Tue, May 12, 2015 at 08:59:03PM

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-13 Thread Rafael J. Wysocki
On Tuesday, May 12, 2015 05:32:29 PM Dmitry Torokhov wrote: > On Wed, May 13, 2015 at 02:22:50AM +0200, Rafael J. Wysocki wrote: > > On Tuesday, May 12, 2015 11:07:33 AM Dmitry Torokhov wrote: > > > On Tue, May 12, 2015 at 08:59:03PM +0300, grygorii.stras...@linaro.org > > > wrote: > > > > On 05/1

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-12 Thread Dmitry Torokhov
On Wed, May 13, 2015 at 02:22:50AM +0200, Rafael J. Wysocki wrote: > On Tuesday, May 12, 2015 11:07:33 AM Dmitry Torokhov wrote: > > On Tue, May 12, 2015 at 08:59:03PM +0300, grygorii.stras...@linaro.org > > wrote: > > > On 05/12/2015 07:42 PM, Dmitry Torokhov wrote: > > > > On Tue, May 12, 2015 a

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-12 Thread Rafael J. Wysocki
On Tuesday, May 12, 2015 11:07:33 AM Dmitry Torokhov wrote: > On Tue, May 12, 2015 at 08:59:03PM +0300, grygorii.stras...@linaro.org wrote: > > On 05/12/2015 07:42 PM, Dmitry Torokhov wrote: > > > On Tue, May 12, 2015 at 04:55:39PM +0300, grygorii.stras...@linaro.org > > > wrote: > > >> On 05/09/2

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-12 Thread Dmitry Torokhov
On Tue, May 12, 2015 at 08:59:03PM +0300, grygorii.stras...@linaro.org wrote: > On 05/12/2015 07:42 PM, Dmitry Torokhov wrote: > > On Tue, May 12, 2015 at 04:55:39PM +0300, grygorii.stras...@linaro.org > > wrote: > >> On 05/09/2015 12:05 AM, Dmitry Torokhov wrote: > >>> On Fri, May 08, 2015 at 10:

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-12 Thread grygorii.stras...@linaro.org
On 05/12/2015 07:42 PM, Dmitry Torokhov wrote: > On Tue, May 12, 2015 at 04:55:39PM +0300, grygorii.stras...@linaro.org wrote: >> On 05/09/2015 12:05 AM, Dmitry Torokhov wrote: >>> On Fri, May 08, 2015 at 10:59:04PM +0200, Geert Uytterhoeven wrote: On Fri, May 8, 2015 at 7:19 PM, Dmitry Torokh

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-12 Thread Dmitry Torokhov
On Tue, May 12, 2015 at 04:55:39PM +0300, grygorii.stras...@linaro.org wrote: > Hi Dmitry, > On 05/09/2015 12:05 AM, Dmitry Torokhov wrote: > > On Fri, May 08, 2015 at 10:59:04PM +0200, Geert Uytterhoeven wrote: > >> On Fri, May 8, 2015 at 7:19 PM, Dmitry Torokhov > >> wrote: > >>> On Fri, May 08,

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-12 Thread grygorii.stras...@linaro.org
Hi Dmitry, On 05/09/2015 12:05 AM, Dmitry Torokhov wrote: > On Fri, May 08, 2015 at 10:59:04PM +0200, Geert Uytterhoeven wrote: >> On Fri, May 8, 2015 at 7:19 PM, Dmitry Torokhov >> wrote: >>> On Fri, May 08, 2015 at 10:47:43AM +0200, Geert Uytterhoeven wrote: In the final iteration of commit

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-08 Thread Dmitry Torokhov
On Fri, May 08, 2015 at 10:59:04PM +0200, Geert Uytterhoeven wrote: > On Fri, May 8, 2015 at 7:19 PM, Dmitry Torokhov > wrote: > > On Fri, May 08, 2015 at 10:47:43AM +0200, Geert Uytterhoeven wrote: > >> In the final iteration of commit 245bd6f6af8a62a2 ("PM / clock_ops: Add > >> pm_clk_add_clk()"

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-08 Thread Geert Uytterhoeven
On Fri, May 8, 2015 at 7:19 PM, Dmitry Torokhov wrote: > On Fri, May 08, 2015 at 10:47:43AM +0200, Geert Uytterhoeven wrote: >> In the final iteration of commit 245bd6f6af8a62a2 ("PM / clock_ops: Add >> pm_clk_add_clk()"), a refcount increment was added by Grygorii Strashko. >> However, the accomp

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-08 Thread Dmitry Torokhov
On Fri, May 08, 2015 at 10:47:43AM +0200, Geert Uytterhoeven wrote: > In the final iteration of commit 245bd6f6af8a62a2 ("PM / clock_ops: Add > pm_clk_add_clk()"), a refcount increment was added by Grygorii Strashko. > However, the accompanying IS_ERR() check operates on the wrong clock > pointer,

[PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-08 Thread Geert Uytterhoeven
In the final iteration of commit 245bd6f6af8a62a2 ("PM / clock_ops: Add pm_clk_add_clk()"), a refcount increment was added by Grygorii Strashko. However, the accompanying IS_ERR() check operates on the wrong clock pointer, which is always zero at this point, i.e. not an error. This may lead to a NU