Re: [PATCH] PM / devfreq: Return -ENODEV from try_then_request_governor

2019-04-23 Thread Tomeu Vizoso
On Tue, 23 Apr 2019 at 11:56, Enric Balletbo i Serra wrote: > > Hi Tomeu, > > On 23/4/19 10:11, Tomeu Vizoso wrote: > > Callers don't expect it to return NULL, but an error code. > > > > Fixes Oops such as the one below, when one tries to set a governor that > > isn't available: > > > > Unable to

Re: [PATCH] PM / devfreq: Return -ENODEV from try_then_request_governor

2019-04-23 Thread Enric Balletbo i Serra
Hi Tomeu, On 23/4/19 10:11, Tomeu Vizoso wrote: > Callers don't expect it to return NULL, but an error code. > > Fixes Oops such as the one below, when one tries to set a governor that > isn't available: > > Unable to handle kernel NULL pointer dereference at virtual address 0018 > > [] (go

[PATCH] PM / devfreq: Return -ENODEV from try_then_request_governor

2019-04-23 Thread Tomeu Vizoso
Callers don't expect it to return NULL, but an error code. Fixes Oops such as the one below, when one tries to set a governor that isn't available: Unable to handle kernel NULL pointer dereference at virtual address 0018 [] (governor_store) from [] (kernfs_fop_write+0x100/0x1e0) [] (kernfs_f