Hello,
There seems to be an inconsistency, but the patch proposed by Coccinelle
does not look correct. There should be a test on opp_table.
julia
---------- Forwarded message ----------
Date: Mon, 1 Mar 2021 16:35:52 +0800
From: kernel test robot <l...@intel.com>
To: kbu...@lists.01.org
Cc: l...@intel.com, Julia Lawall <julia.law...@lip6.fr>
Subject: [PATCH] PM / devfreq: fix odd_ptr_err.cocci warnings
CC: kbuild-...@lists.01.org
TO: Saravana Kannan <skan...@codeaurora.org>
CC: Chanwoo Choi <cw00.c...@samsung.com>
CC: Sibi Sankar <si...@codeaurora.org>
CC: MyungJoo Ham <myungjoo....@samsung.com>
CC: Kyungmin Park <kyungmin.p...@samsung.com>
CC: linux...@vger.kernel.org
CC: linux-kernel@vger.kernel.org
From: kernel test robot <l...@intel.com>
drivers/devfreq/governor_passive.c:318:7-13: inconsistent IS_ERR and PTR_ERR on
line 319.
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call to
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
Fixes: 82d4ff586ae2 ("PM / devfreq: Add cpu based scaling support to passive
governor")
CC: Saravana Kannan <skan...@codeaurora.org>
Reported-by: kernel test robot <l...@intel.com>
Signed-off-by: kernel test robot <l...@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git
devfreq-testing-passive-gov
head: 82d4ff586ae2fb6d89cad871949004bed3438ccb
commit: 82d4ff586ae2fb6d89cad871949004bed3438ccb [3/3] PM / devfreq: Add cpu
based scaling support to passive governor
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
Please take the patch only if it's a positive warning. Thanks!
governor_passive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/devfreq/governor_passive.c
+++ b/drivers/devfreq/governor_passive.c
@@ -316,7 +316,7 @@ static int cpufreq_passive_register(stru
opp_table = dev_pm_opp_get_opp_table(cpu_dev);
if (IS_ERR(devfreq->opp_table)) {
- ret = PTR_ERR(opp_table);
+ ret = PTR_ERR(devfreq->opp_table);
goto out;
}
