Re: [PATCH] PM / sleep: add configurable delay for pm_test

2015-02-22 Thread Brian Norris
On Sun, Feb 22, 2015 at 12:24:29AM +0100, Pavel Machek wrote: > And you also want to check the kernel parameters, they are modifiable > in runtime in at least same cases. I forgot about this fact. In this case, I think this satisfies all that we need. So we can do something like this at runtime:

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2015-02-21 Thread Pavel Machek
On Sat 2015-02-21 14:56:01, Florian Fainelli wrote: > 2015-02-21 12:32 GMT-08:00 Pavel Machek : > > > > > > > >> Considering that Brian's change are enclosed within a CONFIG_PM_DEBUG > >> ifdef, can we really use the code bloat as a technical argument here? > > > > Yes. > > Help me understand a fe

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2015-02-21 Thread Florian Fainelli
2015-02-21 12:32 GMT-08:00 Pavel Machek : > > > >> Considering that Brian's change are enclosed within a CONFIG_PM_DEBUG >> ifdef, can we really use the code bloat as a technical argument here? > > Yes. Help me understand a few things here: - this particular change is enclosed within a debug opti

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2015-02-21 Thread Pavel Machek
> Considering that Brian's change are enclosed within a CONFIG_PM_DEBUG > ifdef, can we really use the code bloat as a technical argument here? Yes. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictur

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2015-02-21 Thread Florian Fainelli
2014-12-17 1:22 GMT-08:00 Pavel Machek : > >> > Make it module parameter so that the patch is two lines of code. If >> > that does not work for you, think of something that does. >> >> OK, so that's actually constructive. If lines of code is really the most >> important factor here, then I suppose

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2014-12-17 Thread Pavel Machek
> > Make it module parameter so that the patch is two lines of code. If > > that does not work for you, think of something that does. > > OK, so that's actually constructive. If lines of code is really the most > important factor here, then I suppose I can do that. I'd argue that a > module param

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2014-12-17 Thread Brian Norris
On Wed, Dec 17, 2014 at 09:09:47AM +0100, Pavel Machek wrote: > > > > 40 lines of code, and new sysfs interface for use by someone who puts > > > the probes on board, anyway... (so should be able to add the single > > > mdelay himself). > > > > I heard your complaint the first time: > > > > ht

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2014-12-17 Thread Pavel Machek
> > 40 lines of code, and new sysfs interface for use by someone who puts > > the probes on board, anyway... (so should be able to add the single > > mdelay himself). > > I heard your complaint the first time: > > https://lkml.org/lkml/2014/9/4/63 > > And I responded to it already: > > htt

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2014-12-16 Thread Brian Norris
On Sat, Dec 13, 2014 at 09:31:23AM +0100, Pavel Machek wrote: > On Fri 2014-12-12 18:55:30, Brian Norris wrote: > > On Wed, Sep 03, 2014 at 04:55:35PM -0700, Brian Norris wrote: > > > When CONFIG_PM_DEBUG=y, we provide a sysfs file (/sys/power/pm_test) for > > > selecting one of a few suspend test

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2014-12-13 Thread Pavel Machek
On Fri 2014-12-12 18:55:30, Brian Norris wrote: > Hi Rafael, > > On Wed, Sep 03, 2014 at 04:55:35PM -0700, Brian Norris wrote: > > When CONFIG_PM_DEBUG=y, we provide a sysfs file (/sys/power/pm_test) for > > selecting one of a few suspend test modes, where rather than entering a > > full suspend s

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2014-12-12 Thread Brian Norris
Hi Rafael, On Wed, Sep 03, 2014 at 04:55:35PM -0700, Brian Norris wrote: > When CONFIG_PM_DEBUG=y, we provide a sysfs file (/sys/power/pm_test) for > selecting one of a few suspend test modes, where rather than entering a > full suspend state, the kernel will perform some subset of suspend > steps

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2014-09-04 Thread Chirantan Ekbote
On Thu, Sep 4, 2014 at 10:54 AM, Brian Norris wrote: > On Thu, Sep 04, 2014 at 09:14:12AM +0200, Pavel Machek wrote: >> > When CONFIG_PM_DEBUG=y, we provide a sysfs file (/sys/power/pm_test) for >> > selecting one of a few suspend test modes, where rather than entering a >> > full suspend state, t

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2014-09-04 Thread Brian Norris
On Thu, Sep 04, 2014 at 09:14:12AM +0200, Pavel Machek wrote: > > When CONFIG_PM_DEBUG=y, we provide a sysfs file (/sys/power/pm_test) for > > selecting one of a few suspend test modes, where rather than entering a > > full suspend state, the kernel will perform some subset of suspend > > steps, wa

Re: [PATCH] PM / sleep: add configurable delay for pm_test

2014-09-04 Thread Pavel Machek
Hi! > When CONFIG_PM_DEBUG=y, we provide a sysfs file (/sys/power/pm_test) for > selecting one of a few suspend test modes, where rather than entering a > full suspend state, the kernel will perform some subset of suspend > steps, wait 5 seconds, and then resume back to normal operation. > > This

[PATCH] PM / sleep: add configurable delay for pm_test

2014-09-03 Thread Brian Norris
When CONFIG_PM_DEBUG=y, we provide a sysfs file (/sys/power/pm_test) for selecting one of a few suspend test modes, where rather than entering a full suspend state, the kernel will perform some subset of suspend steps, wait 5 seconds, and then resume back to normal operation. This mode is useful f