Re: [PATCH] PPP synchronous tty: convert dead_sem to completion

2007-12-09 Thread Matthias Kaehlcke
El Sun, Dec 09, 2007 at 12:04:48PM -0500 Charlie Brady ha dit: > > On Sat, 8 Dec 2007, Matthias Kaehlcke wrote: > >> PPP synchronous tty channel driver: convert the semaphore dead_sem to >> a completion >> >> Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> > > Excuse my ignorance please, but

Re: [PATCH] PPP synchronous tty: convert dead_sem to completion

2007-12-09 Thread Charlie Brady
On Sat, 8 Dec 2007, Matthias Kaehlcke wrote: PPP synchronous tty channel driver: convert the semaphore dead_sem to a completion Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> Excuse my ignorance please, but why is this a good idea? Should we not record the reason for changes? -- To

Re: [PATCH] PPP synchronous tty: convert dead_sem to completion

2007-12-09 Thread Charlie Brady
On Sat, 8 Dec 2007, Matthias Kaehlcke wrote: PPP synchronous tty channel driver: convert the semaphore dead_sem to a completion Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] Excuse my ignorance please, but why is this a good idea? Should we not record the reason for changes? -- To

Re: [PATCH] PPP synchronous tty: convert dead_sem to completion

2007-12-09 Thread Matthias Kaehlcke
El Sun, Dec 09, 2007 at 12:04:48PM -0500 Charlie Brady ha dit: On Sat, 8 Dec 2007, Matthias Kaehlcke wrote: PPP synchronous tty channel driver: convert the semaphore dead_sem to a completion Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] Excuse my ignorance please, but why is this a

[PATCH] PPP synchronous tty: convert dead_sem to completion

2007-12-08 Thread Matthias Kaehlcke
PPP synchronous tty channel driver: convert the semaphore dead_sem to a completion Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> -- diff --git a/drivers/net/ppp_synctty.c b/drivers/net/ppp_synctty.c index f0c6a19..f7472c8 100644 --- a/drivers/net/ppp_synctty.c +++

[PATCH] PPP synchronous tty: convert dead_sem to completion

2007-12-08 Thread Matthias Kaehlcke
PPP synchronous tty channel driver: convert the semaphore dead_sem to a completion Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/net/ppp_synctty.c b/drivers/net/ppp_synctty.c index f0c6a19..f7472c8 100644 --- a/drivers/net/ppp_synctty.c +++