Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-07-10 Thread David Brownell
On Monday 09 July 2007, Rodolfo Giometti wrote: > On Sat, Jun 30, 2007 at 06:46:14AM -0700, David Brownell wrote: > > > > Has someone actually signed up to develop and maintain such a > > controller driver? If so, that would be a Fine Thing, but not > > one I've heard rumored before. I've

Re: [PATCH] PXA27x UDC driver.

2007-07-10 Thread Lothar Wassmann
Hi, > > > +static int > > > +write_packet(volatile u32 * uddr, struct pxa27x_request *req, unsigned > > > max) > > > > Please review Documentation/volatile-considered-harmful.txt > > The attibute volatile here is necessary in order to avoid getting the > following warnings from the compiler: >

Re: [PATCH] PXA27x UDC driver.

2007-07-10 Thread Rodolfo Giometti
On Thu, Jun 28, 2007 at 02:29:49PM -0700, Andrew Morton wrote: > > > > + > > +static int > > +write_packet(volatile u32 * uddr, struct pxa27x_request *req, unsigned max) > > Please review Documentation/volatile-considered-harmful.txt The attibute volatile here is necessary in order to avoid

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-07-10 Thread Vernon Sauder
Rodolfo Giometti wrote: That's what I wish to do... I wish cleaning up as much possible my pxa27x version af the driver so we can have something common where we can work on. Sorry for the delay but in these next days I'll read back all your suggestions and I'll provide a new patch ASAP.

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-07-10 Thread Vernon Sauder
Rodolfo Giometti wrote: That's what I wish to do... I wish cleaning up as much possible my pxa27x version af the driver so we can have something common where we can work on. Sorry for the delay but in these next days I'll read back all your suggestions and I'll provide a new patch ASAP.

Re: [PATCH] PXA27x UDC driver.

2007-07-10 Thread Rodolfo Giometti
On Thu, Jun 28, 2007 at 02:29:49PM -0700, Andrew Morton wrote: + +static int +write_packet(volatile u32 * uddr, struct pxa27x_request *req, unsigned max) Please review Documentation/volatile-considered-harmful.txt The attibute volatile here is necessary in order to avoid getting the

Re: [PATCH] PXA27x UDC driver.

2007-07-10 Thread Lothar Wassmann
Hi, +static int +write_packet(volatile u32 * uddr, struct pxa27x_request *req, unsigned max) Please review Documentation/volatile-considered-harmful.txt The attibute volatile here is necessary in order to avoid getting the following warnings from the compiler: [...] Do you

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-07-10 Thread David Brownell
On Monday 09 July 2007, Rodolfo Giometti wrote: On Sat, Jun 30, 2007 at 06:46:14AM -0700, David Brownell wrote: Has someone actually signed up to develop and maintain such a controller driver? If so, that would be a Fine Thing, but not one I've heard rumored before. I've assumed that

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-07-09 Thread Rodolfo Giometti
On Sat, Jun 30, 2007 at 06:46:14AM -0700, David Brownell wrote: > > Has someone actually signed up to develop and maintain such a > controller driver? If so, that would be a Fine Thing, but not > one I've heard rumored before. I've assumed that the best we'd > have is someone (Rodolfo?!)

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-07-09 Thread Rodolfo Giometti
On Sat, Jun 30, 2007 at 06:46:14AM -0700, David Brownell wrote: Has someone actually signed up to develop and maintain such a controller driver? If so, that would be a Fine Thing, but not one I've heard rumored before. I've assumed that the best we'd have is someone (Rodolfo?!) finally

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-07-02 Thread Dmitry Krivoschekov
David Brownell wrote: > On Friday 29 June 2007, Dmitry Krivoschekov wrote: >> David Brownell wrote: >>> On Thursday 28 June 2007, Rodolfo Giometti wrote: >>> As suggest by Leo let me propose to you my new patch for PXA27x UDC support. Please, let me know what I have to do for

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-07-02 Thread Dmitry Krivoschekov
David Brownell wrote: On Friday 29 June 2007, Dmitry Krivoschekov wrote: David Brownell wrote: On Thursday 28 June 2007, Rodolfo Giometti wrote: As suggest by Leo let me propose to you my new patch for PXA27x UDC support. Please, let me know what I have to do for kernel inclusion. :)

Re: [PATCH] PXA27x UDC driver.

2007-07-01 Thread David Brownell
On Sunday 01 July 2007, Russell King - ARM Linux wrote: > > > > +#ifdef CONFIG_USB_GADGET_PXA27X > > +#define DEV_CONFIG_SUBSET > > +#endif > > + > > Bad - can we not make this runtime dependent? The #define controls which descriptors are statically linked into every object. I suppose someone

Re: [PATCH] PXA27x UDC driver.

2007-07-01 Thread Russell King - ARM Linux
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote: > attached you can find new version of my patch for PXA27x UDC driver > support against kernel 2.6.22-rc3 (but it applies also ro rc6). > > I'd like to know what I have to do in order to prepare this patch for > kernel inclusion.

Re: [PATCH] PXA27x UDC driver.

2007-07-01 Thread Lennert Buytenhek
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote: > attached you can find new version of my patch for PXA27x UDC driver > support against kernel 2.6.22-rc3 (but it applies also ro rc6). > > I'd like to know what I have to do in order to prepare this patch for > kernel inclusion.

Re: [PATCH] PXA27x UDC driver.

2007-07-01 Thread Lennert Buytenhek
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote: attached you can find new version of my patch for PXA27x UDC driver support against kernel 2.6.22-rc3 (but it applies also ro rc6). I'd like to know what I have to do in order to prepare this patch for kernel inclusion. It's

Re: [PATCH] PXA27x UDC driver.

2007-07-01 Thread Russell King - ARM Linux
On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote: attached you can find new version of my patch for PXA27x UDC driver support against kernel 2.6.22-rc3 (but it applies also ro rc6). I'd like to know what I have to do in order to prepare this patch for kernel inclusion. It's

Re: [PATCH] PXA27x UDC driver.

2007-07-01 Thread David Brownell
On Sunday 01 July 2007, Russell King - ARM Linux wrote: +#ifdef CONFIG_USB_GADGET_PXA27X +#define DEV_CONFIG_SUBSET +#endif + Bad - can we not make this runtime dependent? The #define controls which descriptors are statically linked into every object. I suppose someone could

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-06-30 Thread David Brownell
On Thursday 28 June 2007, Andrew Morton wrote: > > +#undef DISABLE_TEST_MODE > > enabling DISABLE_TEST_MODE seens to enable test mode. Confused. Blame it on Intel. ISTR that early pxa2[156]x silicon had something called "test mode". And a boatload of errata, with a common thread in

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-06-30 Thread David Brownell
On Friday 29 June 2007, Dmitry Krivoschekov wrote: > David Brownell wrote: > > On Thursday 28 June 2007, Rodolfo Giometti wrote: > > > >> As suggest by Leo let me propose to you my new patch for PXA27x UDC > >> support. > >> > >> Please, let me know what I have to do for kernel inclusion. :) > > >

Re: [PATCH] PXA27x UDC driver.

2007-06-30 Thread David Brownell
On Friday 29 June 2007, Rodolfo Giometti wrote: > On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote: > > > > Let's start with *JUST* a driver, not trying to update everything > > else in the USB Gadget stack so that it looks like it's designed > > specifically to handle all of

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-06-30 Thread David Brownell
On Friday 29 June 2007, Dmitry Krivoschekov wrote: David Brownell wrote: On Thursday 28 June 2007, Rodolfo Giometti wrote: As suggest by Leo let me propose to you my new patch for PXA27x UDC support. Please, let me know what I have to do for kernel inclusion. :) Let's start with

Re: [PATCH] PXA27x UDC driver.

2007-06-30 Thread David Brownell
On Friday 29 June 2007, Rodolfo Giometti wrote: On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote: Let's start with *JUST* a driver, not trying to update everything else in the USB Gadget stack so that it looks like it's designed specifically to handle all of Intel's design

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-06-30 Thread David Brownell
On Thursday 28 June 2007, Andrew Morton wrote: +#undef DISABLE_TEST_MODE enabling DISABLE_TEST_MODE seens to enable test mode. Confused. Blame it on Intel. ISTR that early pxa2[156]x silicon had something called test mode. And a boatload of errata, with a common thread in

Re: [PATCH] PXA27x UDC driver.

2007-06-29 Thread Andy Isaacson
Thanks for taking the lead on this! I can't wait to have a sane PXA27x gadget driver in mainline. On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote: > +config USB_GADGET_PXA27X > + boolean "PXA 27x" > + depends on ARCH_PXA && PXA27x > + help > +Intel's PXA 27x

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-06-29 Thread Dmitry Krivoschekov
Rodolfo Giometti wrote: > On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote: >> Let's start with *JUST* a driver, not trying to update everything >> else in the USB Gadget stack so that it looks like it's designed >> specifically to handle all of Intel's design botches related to >>

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-06-29 Thread Dmitry Krivoschekov
David Brownell wrote: > On Thursday 28 June 2007, Rodolfo Giometti wrote: > >> As suggest by Leo let me propose to you my new patch for PXA27x UDC >> support. >> >> Please, let me know what I have to do for kernel inclusion. :) > > Let's start with *JUST* a driver, not trying to update everything

Re: [PATCH] PXA27x UDC driver.

2007-06-29 Thread Rodolfo Giometti
On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote: > > Let's start with *JUST* a driver, not trying to update everything > else in the USB Gadget stack so that it looks like it's designed > specifically to handle all of Intel's design botches related to > endpoint config ... and work

Re: [PATCH] PXA27x UDC driver.

2007-06-29 Thread Rodolfo Giometti
On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote: Let's start with *JUST* a driver, not trying to update everything else in the USB Gadget stack so that it looks like it's designed specifically to handle all of Intel's design botches related to endpoint config ... and work

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-06-29 Thread Dmitry Krivoschekov
David Brownell wrote: On Thursday 28 June 2007, Rodolfo Giometti wrote: As suggest by Leo let me propose to you my new patch for PXA27x UDC support. Please, let me know what I have to do for kernel inclusion. :) Let's start with *JUST* a driver, not trying to update everything else in the

Re: [linux-usb-devel] [PATCH] PXA27x UDC driver.

2007-06-29 Thread Dmitry Krivoschekov
Rodolfo Giometti wrote: On Thu, Jun 28, 2007 at 02:53:22PM -0700, David Brownell wrote: Let's start with *JUST* a driver, not trying to update everything else in the USB Gadget stack so that it looks like it's designed specifically to handle all of Intel's design botches related to endpoint

Re: [PATCH] PXA27x UDC driver.

2007-06-29 Thread Andy Isaacson
Thanks for taking the lead on this! I can't wait to have a sane PXA27x gadget driver in mainline. On Thu, Jun 28, 2007 at 12:36:20PM +0200, Rodolfo Giometti wrote: +config USB_GADGET_PXA27X + boolean PXA 27x + depends on ARCH_PXA PXA27x + help +Intel's PXA 27x series

Re: [PATCH] PXA27x UDC driver.

2007-06-28 Thread David Brownell
By the way, there are three or four versions of a pxa27x UDC driver floating around; which one is this? One you updated? It looks like it forked from the pxa2xx driver several years ago but never got cleaned up ... e.g. it's a different controller, so none of the comments relevant to earlier

Re: [PATCH] PXA27x UDC driver.

2007-06-28 Thread David Brownell
On Thursday 28 June 2007, Rodolfo Giometti wrote: > As suggest by Leo let me propose to you my new patch for PXA27x UDC > support. > > Please, let me know what I have to do for kernel inclusion. :) Let's start with *JUST* a driver, not trying to update everything else in the USB Gadget stack so

Re: [PATCH] PXA27x UDC driver.

2007-06-28 Thread Andrew Morton
On Thu, 28 Jun 2007 16:12:07 +0200 Rodolfo Giometti <[EMAIL PROTECTED]> wrote: > On Thu, Jun 28, 2007 at 07:15:06PM +0800, Li Yang-r58472 wrote: > > > You should probably also cc: [EMAIL PROTECTED] and > > David Brownell for UDC matters. > > As suggest by Leo let me propose to you my new patch

RE: [PATCH] PXA27x UDC driver.

2007-06-28 Thread Li Yang-r58472
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Rodolfo Giometti > Sent: Thursday, June 28, 2007 6:36 PM > To: [EMAIL PROTECTED] > Cc: linux-kernel@vger.kernel.org; Andrew Morton > Subject: [PATCH] PXA27x UDC driver. > > H

RE: [PATCH] PXA27x UDC driver.

2007-06-28 Thread Li Yang-r58472
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Rodolfo Giometti Sent: Thursday, June 28, 2007 6:36 PM To: [EMAIL PROTECTED] Cc: linux-kernel@vger.kernel.org; Andrew Morton Subject: [PATCH] PXA27x UDC driver. Hello, attached you can find new

Re: [PATCH] PXA27x UDC driver.

2007-06-28 Thread Andrew Morton
On Thu, 28 Jun 2007 16:12:07 +0200 Rodolfo Giometti [EMAIL PROTECTED] wrote: On Thu, Jun 28, 2007 at 07:15:06PM +0800, Li Yang-r58472 wrote: You should probably also cc: [EMAIL PROTECTED] and David Brownell for UDC matters. As suggest by Leo let me propose to you my new patch for PXA27x

Re: [PATCH] PXA27x UDC driver.

2007-06-28 Thread David Brownell
On Thursday 28 June 2007, Rodolfo Giometti wrote: As suggest by Leo let me propose to you my new patch for PXA27x UDC support. Please, let me know what I have to do for kernel inclusion. :) Let's start with *JUST* a driver, not trying to update everything else in the USB Gadget stack so

Re: [PATCH] PXA27x UDC driver.

2007-06-28 Thread David Brownell
By the way, there are three or four versions of a pxa27x UDC driver floating around; which one is this? One you updated? It looks like it forked from the pxa2xx driver several years ago but never got cleaned up ... e.g. it's a different controller, so none of the comments relevant to earlier