Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-27 Thread Greg KH
On Tue, Aug 27, 2019 at 07:39:50PM +0200, Michal Hocko wrote: > On Tue 27-08-19 19:06:18, Greg KH wrote: > > On Tue, Aug 27, 2019 at 04:10:16PM +0200, Michal Hocko wrote: > > > On Sat 24-08-19 23:23:07, Thomas Backlund wrote: > > > > Den 24-08-2019 kl. 22:57, skrev Andrew Morton: > > > > > On Sat,

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-27 Thread Michal Hocko
On Tue 27-08-19 19:06:18, Greg KH wrote: > On Tue, Aug 27, 2019 at 04:10:16PM +0200, Michal Hocko wrote: > > On Sat 24-08-19 23:23:07, Thomas Backlund wrote: > > > Den 24-08-2019 kl. 22:57, skrev Andrew Morton: > > > > On Sat, 17 Aug 2019 19:15:23 + Roman Gushchin wrote: > > > > > > > > > > >

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-27 Thread Greg KH
On Tue, Aug 27, 2019 at 04:10:16PM +0200, Michal Hocko wrote: > On Sat 24-08-19 23:23:07, Thomas Backlund wrote: > > Den 24-08-2019 kl. 22:57, skrev Andrew Morton: > > > On Sat, 17 Aug 2019 19:15:23 + Roman Gushchin wrote: > > > > > > > > > Fixes: 766a4c19d880 ("mm/memcontrol.c: keep local VM

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-27 Thread Michal Hocko
On Sat 24-08-19 23:23:07, Thomas Backlund wrote: > Den 24-08-2019 kl. 22:57, skrev Andrew Morton: > > On Sat, 17 Aug 2019 19:15:23 + Roman Gushchin wrote: > > > > > > > Fixes: 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > > > > > with the hierarchical ones") > > > > > Sign

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-24 Thread Thomas Backlund
Den 24-08-2019 kl. 22:57, skrev Andrew Morton: On Sat, 17 Aug 2019 19:15:23 + Roman Gushchin wrote: Fixes: 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones") Signed-off-by: Roman Gushchin Cc: Yafang Shao Cc: Johannes Weiner --- mm/memcontrol.c

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-24 Thread Andrew Morton
On Sat, 17 Aug 2019 19:15:23 + Roman Gushchin wrote: > > > Fixes: 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > > > with the hierarchical ones") > > > Signed-off-by: Roman Gushchin > > > Cc: Yafang Shao > > > Cc: Johannes Weiner > > > --- > > > mm/memcontrol.c | 8 +++-

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-23 Thread Yafang Shao
On Sat, Aug 24, 2019 at 6:33 AM Roman Gushchin wrote: > > On Fri, Aug 16, 2019 at 05:47:26PM -0700, Roman Gushchin wrote: > > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > > with the hierarchical ones") effectively decreased the precision of > > per-memcg vmstats_local an

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-23 Thread Roman Gushchin
On Fri, Aug 16, 2019 at 05:47:26PM -0700, Roman Gushchin wrote: > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > with the hierarchical ones") effectively decreased the precision of > per-memcg vmstats_local and per-memcg-per-node lruvec percpu counters. > > That's good for

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-19 Thread Yafang Shao
On Tue, Aug 20, 2019 at 5:20 AM Roman Gushchin wrote: > > On Sun, Aug 18, 2019 at 08:30:15AM +0800, Yafang Shao wrote: > > On Sun, Aug 18, 2019 at 3:14 AM Roman Gushchin wrote: > > > > > > On Sat, Aug 17, 2019 at 11:33:57AM +0800, Yafang Shao wrote: > > > > On Sat, Aug 17, 2019 at 8:47 AM Roman G

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-19 Thread Roman Gushchin
On Sun, Aug 18, 2019 at 08:30:15AM +0800, Yafang Shao wrote: > On Sun, Aug 18, 2019 at 3:14 AM Roman Gushchin wrote: > > > > On Sat, Aug 17, 2019 at 11:33:57AM +0800, Yafang Shao wrote: > > > On Sat, Aug 17, 2019 at 8:47 AM Roman Gushchin wrote: > > > > > > > > Commit 766a4c19d880 ("mm/memcontrol

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-17 Thread Yafang Shao
On Sun, Aug 18, 2019 at 3:14 AM Roman Gushchin wrote: > > On Sat, Aug 17, 2019 at 11:33:57AM +0800, Yafang Shao wrote: > > On Sat, Aug 17, 2019 at 8:47 AM Roman Gushchin wrote: > > > > > > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > > > with the hierarchical ones") eff

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-17 Thread Roman Gushchin
On Sat, Aug 17, 2019 at 08:36:16AM +0200, Greg KH wrote: > On Fri, Aug 16, 2019 at 05:47:26PM -0700, Roman Gushchin wrote: > > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > > with the hierarchical ones") effectively decreased the precision of > > per-memcg vmstats_local an

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-17 Thread Roman Gushchin
On Sat, Aug 17, 2019 at 11:33:57AM +0800, Yafang Shao wrote: > On Sat, Aug 17, 2019 at 8:47 AM Roman Gushchin wrote: > > > > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > > with the hierarchical ones") effectively decreased the precision of > > per-memcg vmstats_local and

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-16 Thread Greg KH
On Fri, Aug 16, 2019 at 05:47:26PM -0700, Roman Gushchin wrote: > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > with the hierarchical ones") effectively decreased the precision of > per-memcg vmstats_local and per-memcg-per-node lruvec percpu counters. > > That's good for

Re: [PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-16 Thread Yafang Shao
On Sat, Aug 17, 2019 at 8:47 AM Roman Gushchin wrote: > > Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync > with the hierarchical ones") effectively decreased the precision of > per-memcg vmstats_local and per-memcg-per-node lruvec percpu counters. > > That's good for display

[PATCH] Partially revert "mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones"

2019-08-16 Thread Roman Gushchin
Commit 766a4c19d880 ("mm/memcontrol.c: keep local VM counters in sync with the hierarchical ones") effectively decreased the precision of per-memcg vmstats_local and per-memcg-per-node lruvec percpu counters. That's good for displaying in memory.stat, but brings a serious regression into the recla