Re: [PATCH] Pinctrl: mvebu - Fix possible NULL derefrence.

2017-01-30 Thread Linus Walleij
On Mon, Jan 30, 2017 at 9:24 AM, Thomas Petazzoni wrote: > On Mon, 30 Jan 2017 10:21:43 +0530, Shailendra Verma wrote: >> of_match_device could return NULL, and so can cause a NULL >> pointer dereference later. >> >> Signed-off-by: Shailendra Verma > > In practice, I don't see how of_match_device

Re: [PATCH] Pinctrl: mvebu - Fix possible NULL derefrence.

2017-01-30 Thread Thomas Petazzoni
Hello, On Mon, 30 Jan 2017 10:21:43 +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma In practice, I don't see how of_match_device() can return NULL here. Indeed, those drivers only suppor

[PATCH] Pinctrl: mvebu - Fix possible NULL derefrence.

2017-01-29 Thread Shailendra Verma
of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/pinctrl/mvebu/pinctrl-dove.c |4 drivers/pinctrl/mvebu/pinctrl-kirkwood.c |4 drivers/pinctrl/mvebu/pinctrl-orion.c|4 3 files chan