Re: [PATCH] RFC: x86/jump_label: Mark arguments as const to satisfy asm constraints

2021-02-12 Thread Josh Poimboeuf
On Thu, Feb 11, 2021 at 01:48:48PM -0800, Jason Gerecke wrote: > When compiling an external kernel module with `-O0` or `-O1`, the following > compile error may be reported: > > ./arch/x86/include/asm/jump_label.h:25:2: error: impossible constraint in > ‘asm’ >25 | asm_volatile_goto(

Re: [PATCH] RFC: x86/jump_label: Mark arguments as const to satisfy asm constraints

2021-02-12 Thread Jason Gerecke
On Fri, Feb 12, 2021 at 7:27 AM Peter Zijlstra wrote: > > On Fri, Feb 12, 2021 at 09:40:59AM -0500, Steven Rostedt wrote: > > On Thu, 11 Feb 2021 13:48:48 -0800 > > Jason Gerecke wrote: > > > > > When compiling an external kernel module with `-O0` or `-O1`, the > > > following > > > compile erro

Re: [PATCH] RFC: x86/jump_label: Mark arguments as const to satisfy asm constraints

2021-02-12 Thread Peter Zijlstra
On Fri, Feb 12, 2021 at 09:40:59AM -0500, Steven Rostedt wrote: > On Thu, 11 Feb 2021 13:48:48 -0800 > Jason Gerecke wrote: > > > When compiling an external kernel module with `-O0` or `-O1`, the following > > compile error may be reported: > > > > ./arch/x86/include/asm/jump_label.h:25:2: e

Re: [PATCH] RFC: x86/jump_label: Mark arguments as const to satisfy asm constraints

2021-02-12 Thread Steven Rostedt
On Thu, 11 Feb 2021 13:48:48 -0800 Jason Gerecke wrote: > When compiling an external kernel module with `-O0` or `-O1`, the following > compile error may be reported: > > ./arch/x86/include/asm/jump_label.h:25:2: error: impossible constraint in > ‘asm’ >25 | asm_volatile_goto("1:"

[PATCH] RFC: x86/jump_label: Mark arguments as const to satisfy asm constraints

2021-02-11 Thread Jason Gerecke
When compiling an external kernel module with `-O0` or `-O1`, the following compile error may be reported: ./arch/x86/include/asm/jump_label.h:25:2: error: impossible constraint in ‘asm’ 25 | asm_volatile_goto("1:" | ^ It appears that these lower optimizati