Re: [PATCH] Rationalise ACPI backlight implementation

2008-02-06 Thread Romano Giannetti
On Sat, 2008-02-02 at 09:30 -0200, Henrique de Moraes Holschuh wrote: > On Fri, 01 Feb 2008, Len Brown wrote: > > You might check if CONFIG_ACPI_VIDEO=m is set and you can load the "video" > > module. > > While the sony may be non-standard and not load, your thinkpad may work. [...] > > We real

Re: [PATCH] Rationalise ACPI backlight implementation

2008-02-02 Thread Henrique de Moraes Holschuh
On Fri, 01 Feb 2008, Len Brown wrote: > You might check if CONFIG_ACPI_VIDEO=m is set and you can load the "video" > module. > While the sony may be non-standard and not load, your thinkpad may work. It will work except under new X.org, which disables BIOS backlight functionality in order to do i

Re: [PATCH] Rationalise ACPI backlight implementation

2008-02-01 Thread Len Brown
On Monday 28 January 2008 00:10, Andrew Morton wrote: > On Mon, 28 Jan 2008 01:25:50 + Matthew Garrett <[EMAIL PROTECTED]> wrote: > > > On Sat, Jan 26, 2008 at 10:00:45PM -0800, Andrew Morton wrote: > > > - Create a new /sys node with a new name which has the new semantics. > > > > The semant

Re: [PATCH] Rationalise ACPI backlight implementation

2008-02-01 Thread Len Brown
Applied. thanks, -Len On Tuesday 25 December 2007 21:03, Matthew Garrett wrote: > The sysfs backlight class provides no mechanism for querying the > acceptable brightness for a backlight. The ACPI spec states that values > are only valid if they are reported as available by the firmware. Since

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-28 Thread Henrique de Moraes Holschuh
On Sun, 27 Jan 2008, Andrew Morton wrote: > 0 sh -c "echo $1 > /sys/class/backlight/thinkpad_screen/brightness" > ) 2>/dev/null > > And yes, I had an rc.local command which assumed that 7 (later 8) is max > brightness. You have to use 15 (or 16? I forget) on T61, X61, R61, X60(I think)... for max

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-27 Thread Matthew Garrett
On Sun, Jan 27, 2008 at 09:10:13PM -0800, Andrew Morton wrote: > You cannot seriously tell me that if we are to change this range from 0-8 > up to 0-100 then this is not a backwards-incompatible change in > semantics. We're talking about changing 0-100 to 0-something sane, because the current dr

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-27 Thread Andrew Morton
On Mon, 28 Jan 2008 01:25:50 + Matthew Garrett <[EMAIL PROTECTED]> wrote: > On Sat, Jan 26, 2008 at 10:00:45PM -0800, Andrew Morton wrote: > > - Create a new /sys node with a new name which has the new semantics. > > The semantics are the same as they always have been - values between 0 > an

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-27 Thread Matthew Garrett
On Sat, Jan 26, 2008 at 10:00:45PM -0800, Andrew Morton wrote: > - Create a new /sys node with a new name which has the new semantics. The semantics are the same as they always have been - values between 0 and max_brightness are valid values. If you've made assumptions about what max_brightness

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-26 Thread Andrew Morton
> On Thu, 24 Jan 2008 16:44:48 -0500 Len Brown <[EMAIL PROTECTED]> wrote: > On Tuesday 25 December 2007 21:03, Matthew Garrett wrote: > > The sysfs backlight class provides no mechanism for querying the > > acceptable brightness for a backlight. The ACPI spec states that values > > are only valid

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-26 Thread Matthew Garrett
On Thu, Jan 24, 2008 at 04:44:48PM -0500, Len Brown wrote: > On Tuesday 25 December 2007 21:03, Matthew Garrett wrote: > > The sysfs backlight class provides no mechanism for querying the > > acceptable brightness for a backlight. The ACPI spec states that values > > are only valid if they are re

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-24 Thread Len Brown
On Tuesday 25 December 2007 21:03, Matthew Garrett wrote: > The sysfs backlight class provides no mechanism for querying the > acceptable brightness for a backlight. The ACPI spec states that values > are only valid if they are reported as available by the firmware. Since > we can't provide that

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-22 Thread Henrique de Moraes Holschuh
On Tue, 22 Jan 2008, Matthew Garrett wrote: > On Tue, Jan 22, 2008 at 04:33:29PM +0800, Zhang Rui wrote: > > I have no obvious objection on either of these two proposals. > > But one thing to mention is that > > both of these two patches is written on the assumption that the > > brightness levels l

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-22 Thread Matthew Garrett
On Tue, Jan 22, 2008 at 04:33:29PM +0800, Zhang Rui wrote: > I have no obvious objection on either of these two proposals. > But one thing to mention is that > both of these two patches is written on the assumption that the > brightness levels listed in _BCL method are in ascending order, while >

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-22 Thread Zhang Rui
On Wed, 2007-12-26 at 02:03 +, Matthew Garrett wrote: > The sysfs backlight class provides no mechanism for querying the > acceptable brightness for a backlight. The ACPI spec states that values > are only valid if they are reported as available by the firmware. Since > we can't provide that

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-13 Thread Matthew Garrett
Len, I've had no feedback on this - the backlight maintainer thinks it's the right way to go, so I'd like to get it queued for .25 at least. -- Matthew Garrett | [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECT

[PATCH] Rationalise ACPI backlight implementation

2007-12-25 Thread Matthew Garrett
The sysfs backlight class provides no mechanism for querying the acceptable brightness for a backlight. The ACPI spec states that values are only valid if they are reported as available by the firmware. Since we can't provide that information to userspace, instead collapse the range to the numb