Re: [PATCH] Reap dead swap cache earlier v2

2001-06-07 Thread Jonathan Morton
>> >As suggested by Linus, I've cleaned the reapswap code to be contained >> >inside an inline function. (yes, the if statement is really ugly) >> >> I can't seem to find the patch which adds this behaviour to the background >> scanning. > >I've just sent Linus a patch to free swap cache pages at

Re: [PATCH] Reap dead swap cache earlier v2

2001-06-07 Thread Marcelo Tosatti
On Thu, 7 Jun 2001, Jonathan Morton wrote: > >As suggested by Linus, I've cleaned the reapswap code to be contained > >inside an inline function. (yes, the if statement is really ugly) > > I can't seem to find the patch which adds this behaviour to the background > scanning. I've just sent

Re: [PATCH] Reap dead swap cache earlier v2

2001-06-07 Thread Jonathan Morton
>As suggested by Linus, I've cleaned the reapswap code to be contained >inside an inline function. (yes, the if statement is really ugly) I can't seem to find the patch which adds this behaviour to the background scanning. Can someone point me to it?

Re: [PATCH] Reap dead swap cache earlier v2

2001-06-07 Thread Hugh Dickins
On Thu, 7 Jun 2001, John Stoffel wrote: > Shouldn't the "swap_count(page) == 1" check be earlier in the if > statement, so we can fall through more quickly if there is no work to > be done? A small optimization, but putting the common cases first > will help. I don't think so: the out-of-line sw

Re: [PATCH] Reap dead swap cache earlier v2

2001-06-07 Thread John Stoffel
Marcelo> As suggested by Linus, I've cleaned the reapswap code to be Marcelo> contained inside an inline function. (yes, the if statement Marcelo> is really ugly) Shouldn't the "swap_count(page) == 1" check be earlier in the if statement, so we can fall through more quickly if there is no work t

[PATCH] Reap dead swap cache earlier v2

2001-06-06 Thread Marcelo Tosatti
Hi, As suggested by Linus, I've cleaned the reapswap code to be contained inside an inline function. (yes, the if statement is really ugly) Tested and against 2.4.6pre1. --- linux.orig/mm/vmscan.c Wed Jun 6 18:16:45 2001 +++ linux/mm/vmscan.c Wed Jun 6 18:28:26 2001 @@ -407,6 +40