Re: [PATCH] Remove #warnings for longstanding conditions.

2007-10-25 Thread Jeff Garzik
Matthew Wilcox wrote: On Thu, Oct 25, 2007 at 10:07:17PM -0400, Jeff Garzik wrote: Is this warning of value to anybody but you? Yup. It signals this driver isn't production quality yet. Is this information worth printing out on everyone else's kernel build? I thnk that's worth noting to a

Re: [PATCH] Remove #warnings for longstanding conditions.

2007-10-25 Thread Matthew Wilcox
On Thu, Oct 25, 2007 at 10:07:17PM -0400, Jeff Garzik wrote: > Is this warning of value to anybody but you? Yup. It signals this driver isn't production quality yet. > Is this information worth printing out on everyone else's kernel build? I thnk that's worth noting to anyone who's enabled it.

Re: [PATCH] Remove #warnings for longstanding conditions.

2007-10-25 Thread Jeff Garzik
Matthew Wilcox wrote: drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API I'll be removing this #warning from advansys when I get rid of the last bus_to_virt. Which I've already done ... it's just that the resulting driver works on i386,

Re: [PATCH] Remove #warnings for longstanding conditions.

2007-10-25 Thread Matthew Wilcox
On Thu, Oct 25, 2007 at 04:06:15AM -0400, Jeff Garzik wrote: > drivers/scsi/advansys.c:71:2: warning: #warning this driver is still > not properly converted to the DMA API > > ...represent conditions that have existed for years, and are duly noted > in FIXMEs. There does not seem to be much need

Re: [PATCH] Remove #warnings for longstanding conditions.

2007-10-25 Thread Karsten Keil
On Thu, Oct 25, 2007 at 04:06:15AM -0400, Jeff Garzik wrote: > These two warnings... > > drivers/isdn/capi/capidrv.c:2126:3: warning: #warning FIXME: maybe a > race condition the card should be removed here from global list /kkeil > > drivers/scsi/advansys.c:71:2: warning: #warning this driver is

[PATCH] Remove #warnings for longstanding conditions.

2007-10-25 Thread Jeff Garzik
These two warnings... drivers/isdn/capi/capidrv.c:2126:3: warning: #warning FIXME: maybe a race condition the card should be removed here from global list /kkeil drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API ...represent conditions tha