Patrick McHardy <[EMAIL PROTECTED]> writes:
> OK lets keep it then. Fixing the race seems overkill to me though.
Me to.
Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/maj
Stephen Hemminger wrote:
On Tue, 25 Sep 2007 06:07:24 +0200
Patrick McHardy <[EMAIL PROTECTED]> wrote:
I meant removing brnf_sysctl_call_tables function, not the sysctls
themselves, all it does is change values != 0 to 1. Or did you
actually mean that something in userspace might depend on r
On Tue, 25 Sep 2007 06:07:24 +0200
Patrick McHardy <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger wrote:
> > On Mon, 24 Sep 2007 18:55:38 +0200
> > Patrick McHardy <[EMAIL PROTECTED]> wrote:
> >
> >>Eric W. Biederman wrote:
> >>
> >>>A really good fix would be to remove the binary side and then t
Eric W. Biederman wrote:
> Patrick McHardy <[EMAIL PROTECTED]> writes:
>
>>I seem to be missing something, the entire brnf_sysctl_call_tables
>>thing looks purely cosmetic to me, wouldn't it be better to simply
>>remove it?
>
>
> Well it is cosmetic in a user space visible way. Which means I do
Patrick McHardy <[EMAIL PROTECTED]> writes:
>> Hmm. This is an interesting case. The proc method is forcing
>> the integer to be either 0 or 1 in a racy fashion. But none of the
>> users appear to depend upon that.
>>
>> So this is the least broken set of binary sysctls I have seen caught
>> b
Stephen Hemminger wrote:
> On Mon, 24 Sep 2007 18:55:38 +0200
> Patrick McHardy <[EMAIL PROTECTED]> wrote:
>
>>Eric W. Biederman wrote:
>>
>>>A really good fix would be to remove the binary side and then to
>>>modify brnf_sysctl_call_tables to allocate a temporary ctl_table and
>>>integer on the s
On Mon, 24 Sep 2007 18:55:38 +0200
Patrick McHardy <[EMAIL PROTECTED]> wrote:
> Eric W. Biederman wrote:
> > [EMAIL PROTECTED] (Joseph Fannin) writes:
> >
> >
> >>The netfilter sysctls in the bridging code don't set strategy routines:
> >>
> >> sysctl table check failed: /net/bridge/bridge-nf-ca
Eric W. Biederman wrote:
> [EMAIL PROTECTED] (Joseph Fannin) writes:
>
>
>>The netfilter sysctls in the bridging code don't set strategy routines:
>>
>> sysctl table check failed: /net/bridge/bridge-nf-call-arptables .3.10.1
>> Missing
>>strategy
>> sysctl table check failed: /net/bridge/bridge-
[EMAIL PROTECTED] (Joseph Fannin) writes:
> The netfilter sysctls in the bridging code don't set strategy routines:
>
> sysctl table check failed: /net/bridge/bridge-nf-call-arptables .3.10.1
> Missing
> strategy
> sysctl table check failed: /net/bridge/bridge-nf-call-iptables .3.10.2
> Missin
The netfilter sysctls in the bridging code don't set strategy routines:
sysctl table check failed: /net/bridge/bridge-nf-call-arptables .3.10.1
Missing strategy
sysctl table check failed: /net/bridge/bridge-nf-call-iptables .3.10.2 Missing
strategy
sysctl table check failed: /net/bridge/bridg
10 matches
Mail list logo