Re: [PATCH] Remove race between con_open and con_close

2005-08-27 Thread Paul Mackerras
Russell King writes: > Have you looked at how serial_core handles this kind of problem in > its open and close methods? I put some comments in there because > of the issue, after thinking about it fairly carefully. Yes, albeit briefly; the problem in con_open is much simpler because we never nee

Re: [PATCH] Remove race between con_open and con_close

2005-08-27 Thread Russell King
On Sun, Aug 28, 2005 at 09:40:01AM +1000, Paul Mackerras wrote: > I have a laptop (G3 powerbook) which will pretty reliably hit a race > between con_open and con_close late in the boot process and oops in > vt_ioctl due to tty->driver_data being NULL. Have you looked at how serial_core handles thi

Re: [PATCH] Remove race between con_open and con_close

2005-08-27 Thread Antonino A. Daplas
Paul Mackerras wrote: I have a laptop (G3 powerbook) which will pretty reliably hit a race between con_open and con_close late in the boot process and oops in vt_ioctl due to tty->driver_data being NULL. What happens is this: process A opens /dev/tty6; it comes into con_open() (drivers/char/vt.c

[PATCH] Remove race between con_open and con_close

2005-08-27 Thread Paul Mackerras
I have a laptop (G3 powerbook) which will pretty reliably hit a race between con_open and con_close late in the boot process and oops in vt_ioctl due to tty->driver_data being NULL. What happens is this: process A opens /dev/tty6; it comes into con_open() (drivers/char/vt.c) and assign a non-NULL