Re: [PATCH] Respond:Patch 0004-Add-support-for-SUNIX-parallel-card

2019-04-01 Thread Enrico Weigelt, metux IT consult
On 29.03.19 12:25, Morris Ku wrote: > Hi, > Thanks for review, my replies are inline: https://www.netmeister.org/news/learn2quote.html > +> +static struct snx_parport_driver snx_lp_driver = { > +> + .name = "lx", > +> + .attach = snx_lp_attach, > +> + .detach = snx_lp_detach, > +> +};

Re: [PATCH] Respond:Patch 0004-Add-support-for-SUNIX-parallel-card

2019-04-01 Thread Lee Jones
On Fri, 29 Mar 2019, Morris Ku wrote: > Hi, > Thanks for review, my replies are inline: I literally have no idea what this is! It's a reply to a diff of a reply to a patch AFAICS! I think the best I can do is point you to: Documentation/process/submitting-patches.rst > Signed-off-by: Morris

[PATCH] Respond:Patch 0004-Add-support-for-SUNIX-parallel-card

2019-03-29 Thread Morris Ku
Hi, Thanks for review, my replies are inline: Signed-off-by: Morris Ku --- @@ -0,0 +1,255 @@ + +On 19.03.19 13:08, Morris Ku wrote: + +> diff --git a/mfd/sunix/snx_ieee1284_ops.c b/mfd/sunix/snx_ieee1284_ops.c +> new file mode 100644 +> index ..2dac03fd +> --- /dev/null + + + +> +size_t s