Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

2018-05-03 Thread Vinod Koul
On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > > The pl330.c pause implementation violates the dmaengine requirement > for no data loss, since it relies on the DMAKILL > instruction. However, DMAKILL discards in-f

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

2018-05-03 Thread Vinod Koul
On Wed, May 02, 2018 at 10:37:09AM -0400, Frank Mori Hess wrote: > On Wed, May 2, 2018 at 12:32 AM, Vinod Koul wrote: > > On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > >> > > > > I am dropping the orignal patch

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

2018-05-02 Thread Frank Mori Hess
On Wed, May 2, 2018 at 12:32 AM, Vinod Koul wrote: > On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: >> This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. >> > > I am dropping the orignal patch for queue, so no need for revert patch. > I don't understand, 88987d2c7534a

Re: [PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

2018-05-01 Thread Vinod Koul
On Sat, Apr 28, 2018 at 05:50:58PM -0400, Frank Mori Hess wrote: > This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. > > The pl330.c pause implementation violates the dmaengine requirement > for no data loss, since it relies on the DMAKILL > instruction. However, DMAKILL discards in-f

[PATCH] Revert "dmaengine: pl330: add DMA_PAUSE feature"

2018-04-28 Thread Frank Mori Hess
This reverts commit 88987d2c7534a0269f567fb101e6d71a08f0f01d. The pl330.c pause implementation violates the dmaengine requirement for no data loss, since it relies on the DMAKILL instruction. However, DMAKILL discards in-flight data from the dma controller's fifo. This is documented in the dma-3