Re: [PATCH] Revert "dynamic_debug: Remove unnecessary __used"

2020-05-11 Thread Joe Perches
On Mon, 2020-05-11 at 12:31 -0700, Elliot Berman wrote: > On 5/11/2020 11:54 AM, Joe Perches wrote> Change-Id: probably isn't necessary. > > Thanks for the catch > > > Is there a separate mechanism possible to avoid bloating the > > otherwise unused content? > > This struct is being used in lib/

Re: [PATCH] Revert "dynamic_debug: Remove unnecessary __used"

2020-05-11 Thread Elliot Berman
On 5/11/2020 11:54 AM, Joe Perches wrote> Change-Id: probably isn't necessary. Thanks for the catch > > Is there a separate mechanism possible to avoid bloating the > otherwise unused content? This struct is being used in lib/dynamic_debug.c but compiler doesn't know about this usage when optim

Re: [PATCH] Revert "dynamic_debug: Remove unnecessary __used"

2020-05-11 Thread Joe Perches
On Mon, 2020-05-11 at 11:26 -0700, Elliot Berman wrote: > This reverts commit c0d2af637863940b1a4fb208224ca7acb905c39f. > > Some compilers[1] may break dynamic_hex_dump by optimizing the > DYNAMIC_DEBUG_BRANCH check inside __dynamic_func_call_no_desc and completely > removing the dynamic debug met

[PATCH] Revert "dynamic_debug: Remove unnecessary __used"

2020-05-11 Thread Elliot Berman
This reverts commit c0d2af637863940b1a4fb208224ca7acb905c39f. Some compilers[1] may break dynamic_hex_dump by optimizing the DYNAMIC_DEBUG_BRANCH check inside __dynamic_func_call_no_desc and completely removing the dynamic debug metadata. Thus, there is no dynamic_debug control site to enable or d