Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-05 Thread Linus Walleij
On Tue, Jul 5, 2016 at 11:12 AM, Johan Hovold wrote: > Your call. :) The patch is on my fixes branch and will go to Torvalds by the end of the week unless I'm convinced otherwise ... It turns out the patch is very isolated and doesn't collide with any gpio development since 4.4 (which is impres

Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-05 Thread Johan Hovold
On Tue, Jul 05, 2016 at 08:54:36AM +0200, Linus Walleij wrote: > On Mon, Jul 4, 2016 at 10:33 PM, Laurent Pinchart > wrote: > > > As we're not dealing with a v4.7 regression that would need to be applied > > this > > week, can't you propose a proper fix instead of a revert ? > > AFAICT the prop

Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-05 Thread Johan Hovold
On Mon, Jul 04, 2016 at 11:33:16PM +0300, Laurent Pinchart wrote: > Hi Johan, > > Thank you for the patch. > > On Sunday 03 Jul 2016 18:32:05 Johan Hovold wrote: > > This reverts commit 923b93e451db876d1479d3e4458fce14fec31d1c. > > > > Make sure consumers do not overwrite gpio flags for pins tha

Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-04 Thread Linus Walleij
On Mon, Jul 4, 2016 at 10:33 PM, Laurent Pinchart wrote: > As we're not dealing with a v4.7 regression that would need to be applied this > week, can't you propose a proper fix instead of a revert ? AFAICT the proper fix is to simply move the gpiod_request() sites earlier, I can propose somethin

Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-04 Thread Linus Walleij
On Mon, Jul 4, 2016 at 10:30 PM, Laurent Pinchart wrote: > On Monday 04 Jul 2016 15:16:40 Linus Walleij wrote: >> On Sun, Jul 3, 2016 at 6:32 PM, Johan Hovold wrote: >> > This reverts commit 923b93e451db876d1479d3e4458fce14fec31d1c. >> >> Laurent, can we have you comment on this? >> >> Getting cl

Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-04 Thread Laurent Pinchart
Hi Johan, Thank you for the patch. On Sunday 03 Jul 2016 18:32:05 Johan Hovold wrote: > This reverts commit 923b93e451db876d1479d3e4458fce14fec31d1c. > > Make sure consumers do not overwrite gpio flags for pins that have > already been claimed. > > While adding support for gpio drivers to refus

Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-04 Thread Laurent Pinchart
On Monday 04 Jul 2016 15:16:40 Linus Walleij wrote: > On Sun, Jul 3, 2016 at 6:32 PM, Johan Hovold wrote: > > This reverts commit 923b93e451db876d1479d3e4458fce14fec31d1c. > > Laurent, can we have you comment on this? > > Getting close to v4.7 final so we need to quickly see if > this is the sol

Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-04 Thread Linus Walleij
On Sun, Jul 3, 2016 at 6:32 PM, Johan Hovold wrote: > This reverts commit 923b93e451db876d1479d3e4458fce14fec31d1c. > > Make sure consumers do not overwrite gpio flags for pins that have > already been claimed. Patch applied for fixes and pushed for build server for testing for now. It looks inn

Re: [PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-04 Thread Linus Walleij
On Sun, Jul 3, 2016 at 6:32 PM, Johan Hovold wrote: > This reverts commit 923b93e451db876d1479d3e4458fce14fec31d1c. Laurent, can we have you comment on this? Getting close to v4.7 final so we need to quickly see if this is the solution or if it will cause further regressions on your side if I r

[PATCH] Revert "gpiolib: Split GPIO flags parsing and GPIO configuration"

2016-07-03 Thread Johan Hovold
This reverts commit 923b93e451db876d1479d3e4458fce14fec31d1c. Make sure consumers do not overwrite gpio flags for pins that have already been claimed. While adding support for gpio drivers to refuse a request using unsupported flags, the order of when the requested flag was checked and the new fl