Re: [PATCH] Revert "net: get rid of an signed integer overflow in ip_idents_reserve()"

2019-09-05 Thread Shaokun Zhang
Hi Eric, On 2019/7/26 17:58, Eric Dumazet wrote: > > > On 7/26/19 11:17 AM, Shaokun Zhang wrote: >> From: Yang Guo >> >> There is an significant performance regression with the following >> commit-id >> ("net: get rid of an signed integer overflow in ip_idents_reserve()"). >> >> > > So, you

Re: [PATCH] Revert "net: get rid of an signed integer overflow in ip_idents_reserve()"

2019-07-26 Thread Eric Dumazet
On 7/26/19 11:17 AM, Shaokun Zhang wrote: > From: Yang Guo > > There is an significant performance regression with the following > commit-id > ("net: get rid of an signed integer overflow in ip_idents_reserve()"). > > So, you jump around and took ownership of this issue, while some of us

[PATCH] Revert "net: get rid of an signed integer overflow in ip_idents_reserve()"

2019-07-26 Thread Shaokun Zhang
From: Yang Guo There is an significant performance regression with the following commit-id ("net: get rid of an signed integer overflow in ip_idents_reserve()"). Both on x86 server(Skylake) and ARM64 server, when cpu core number increase, the function ip_idents_reserve() of cpu usage is very