Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-13 Thread Namhyung Kim
On Thu, Apr 12, 2018 at 07:09:54PM -0500, Kim Phillips wrote: > On Thu, 12 Apr 2018 10:57:56 +0900 > Namhyung Kim wrote: > > > On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > > > On Thu, 12 Apr 2018 08:31:09 +0900 > > > Namhyung Kim

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-13 Thread Namhyung Kim
On Thu, Apr 12, 2018 at 07:09:54PM -0500, Kim Phillips wrote: > On Thu, 12 Apr 2018 10:57:56 +0900 > Namhyung Kim wrote: > > > On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > > > On Thu, 12 Apr 2018 08:31:09 +0900 > > > Namhyung Kim wrote: > > > > overflow can create it.. could

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-12 Thread Kim Phillips
On Thu, 12 Apr 2018 10:57:56 +0900 Namhyung Kim wrote: > On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > > On Thu, 12 Apr 2018 08:31:09 +0900 > > Namhyung Kim wrote: > > > On Wed, Apr 11, 2018 at 06:07:52PM -0500, Kim Phillips wrote: > >

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-12 Thread Kim Phillips
On Thu, 12 Apr 2018 10:57:56 +0900 Namhyung Kim wrote: > On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > > On Thu, 12 Apr 2018 08:31:09 +0900 > > Namhyung Kim wrote: > > > On Wed, Apr 11, 2018 at 06:07:52PM -0500, Kim Phillips wrote: > > > > --- > > > > It's not clear to me what

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-11 Thread Namhyung Kim
On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > On Thu, 12 Apr 2018 08:31:09 +0900 > Namhyung Kim wrote: > > > Hello, > > Hi, > > > On Wed, Apr 11, 2018 at 06:07:52PM -0500, Kim Phillips wrote: > > > --- > > > It's not clear to me what the specific intent

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-11 Thread Namhyung Kim
On Wed, Apr 11, 2018 at 07:29:40PM -0500, Kim Phillips wrote: > On Thu, 12 Apr 2018 08:31:09 +0900 > Namhyung Kim wrote: > > > Hello, > > Hi, > > > On Wed, Apr 11, 2018 at 06:07:52PM -0500, Kim Phillips wrote: > > > --- > > > It's not clear to me what the specific intent of the original commit

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-11 Thread Namhyung Kim
Hello, On Wed, Apr 11, 2018 at 06:07:52PM -0500, Kim Phillips wrote: > perf test 1 is failing on an arm64 box (that has a kernel module > loaded fwiw). Running bisect resulted in commit 1d12cec6ce99 "perf > machine: Fix paranoid check in machine__set_kernel_mmap()" being the > first bad commit.

Re: [PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-11 Thread Namhyung Kim
Hello, On Wed, Apr 11, 2018 at 06:07:52PM -0500, Kim Phillips wrote: > perf test 1 is failing on an arm64 box (that has a kernel module > loaded fwiw). Running bisect resulted in commit 1d12cec6ce99 "perf > machine: Fix paranoid check in machine__set_kernel_mmap()" being the > first bad commit.

[PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-11 Thread Kim Phillips
perf test 1 is failing on an arm64 box (that has a kernel module loaded fwiw). Running bisect resulted in commit 1d12cec6ce99 "perf machine: Fix paranoid check in machine__set_kernel_mmap()" being the first bad commit. Reverting it fixes symbol resolution: # ./perf.bad record true; ./perf.bad

[PATCH] Revert "perf machine: Fix paranoid check in machine__set_kernel_mmap()"

2018-04-11 Thread Kim Phillips
perf test 1 is failing on an arm64 box (that has a kernel module loaded fwiw). Running bisect resulted in commit 1d12cec6ce99 "perf machine: Fix paranoid check in machine__set_kernel_mmap()" being the first bad commit. Reverting it fixes symbol resolution: # ./perf.bad record true; ./perf.bad