Re: [PATCH] Revert "perf tools: Allow to specify custom linker command"

2015-07-14 Thread a...@kernel.org
Em Tue, Jul 14, 2015 at 02:00:05PM +, Alexey Brodkin escreveu: > On Tue, 2015-07-14 at 10:46 -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen escreveu: > > > > But for now to fix cross-building of perf this revert is enough. > > > Hmm. You are

Re: [PATCH] Revert "perf tools: Allow to specify custom linker command"

2015-07-14 Thread Alexey Brodkin
Hi Arnaldo, On Tue, 2015-07-14 at 10:46 -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen escreveu: > > Hi, > > > > On Mon, Jul 13, 2015 at 02:10:53PM +0300, Alexey Brodkin wrote: > > > This reverts commit 5ef7bbb09f7b > > > ("perf tools: Allow to

Re: [PATCH] Revert "perf tools: Allow to specify custom linker command"

2015-07-14 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen escreveu: > Hi, > > On Mon, Jul 13, 2015 at 02:10:53PM +0300, Alexey Brodkin wrote: > > This reverts commit 5ef7bbb09f7b > > ("perf tools: Allow to specify custom linker command"). > > > > LD is a pre-defined variable in GNU Make. I.e. it

Re: [PATCH] Revert "perf tools: Allow to specify custom linker command"

2015-07-14 Thread Jiri Olsa
On Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen wrote: > Hi, > > On Mon, Jul 13, 2015 at 02:10:53PM +0300, Alexey Brodkin wrote: > > This reverts commit 5ef7bbb09f7b > > ("perf tools: Allow to specify custom linker command"). > > > > LD is a pre-defined variable in GNU Make. I.e. it is

Re: [PATCH] Revert perf tools: Allow to specify custom linker command

2015-07-14 Thread Jiri Olsa
On Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen wrote: Hi, On Mon, Jul 13, 2015 at 02:10:53PM +0300, Alexey Brodkin wrote: This reverts commit 5ef7bbb09f7b (perf tools: Allow to specify custom linker command). LD is a pre-defined variable in GNU Make. I.e. it is always

Re: [PATCH] Revert perf tools: Allow to specify custom linker command

2015-07-14 Thread Arnaldo Carvalho de Melo
Em Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen escreveu: Hi, On Mon, Jul 13, 2015 at 02:10:53PM +0300, Alexey Brodkin wrote: This reverts commit 5ef7bbb09f7b (perf tools: Allow to specify custom linker command). LD is a pre-defined variable in GNU Make. I.e. it is always

Re: [PATCH] Revert perf tools: Allow to specify custom linker command

2015-07-14 Thread Alexey Brodkin
Hi Arnaldo, On Tue, 2015-07-14 at 10:46 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen escreveu: Hi, On Mon, Jul 13, 2015 at 02:10:53PM +0300, Alexey Brodkin wrote: This reverts commit 5ef7bbb09f7b (perf tools: Allow to specify custom

Re: [PATCH] Revert perf tools: Allow to specify custom linker command

2015-07-14 Thread a...@kernel.org
Em Tue, Jul 14, 2015 at 02:00:05PM +, Alexey Brodkin escreveu: On Tue, 2015-07-14 at 10:46 -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen escreveu: But for now to fix cross-building of perf this revert is enough. Hmm. You are probably

Re: [PATCH] Revert "perf tools: Allow to specify custom linker command"

2015-07-13 Thread Aaro Koskinen
Hi, On Mon, Jul 13, 2015 at 02:10:53PM +0300, Alexey Brodkin wrote: > This reverts commit 5ef7bbb09f7b > ("perf tools: Allow to specify custom linker command"). > > LD is a pre-defined variable in GNU Make. I.e. it is always defined. > Which means there's no point to check "LD ?= ..." because it

[PATCH] Revert "perf tools: Allow to specify custom linker command"

2015-07-13 Thread Alexey Brodkin
This reverts commit 5ef7bbb09f7b ("perf tools: Allow to specify custom linker command"). LD is a pre-defined variable in GNU Make. I.e. it is always defined. Which means there's no point to check "LD ?= ..." because it will never succeed. And so LD will be either that explicitly passed to make

[PATCH] Revert perf tools: Allow to specify custom linker command

2015-07-13 Thread Alexey Brodkin
This reverts commit 5ef7bbb09f7b (perf tools: Allow to specify custom linker command). LD is a pre-defined variable in GNU Make. I.e. it is always defined. Which means there's no point to check LD ?= ... because it will never succeed. And so LD will be either that explicitly passed to make like

Re: [PATCH] Revert perf tools: Allow to specify custom linker command

2015-07-13 Thread Aaro Koskinen
Hi, On Mon, Jul 13, 2015 at 02:10:53PM +0300, Alexey Brodkin wrote: This reverts commit 5ef7bbb09f7b (perf tools: Allow to specify custom linker command). LD is a pre-defined variable in GNU Make. I.e. it is always defined. Which means there's no point to check LD ?= ... because it will