Re: [PATCH] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"

2020-06-17 Thread Willy Tarreau
Hi Greg, On Wed, Jun 17, 2020 at 12:34:12PM +0200, Greg Kroah-Hartman wrote: > From: Wade Mealing > > Turns out that the permissions for 0400 really are what we want here, > otherwise any user can write to this file. s/write to/read from/ As Wade reported,

Re: [PATCH] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"

2020-06-17 Thread Willy Tarreau
On Wed, Jun 17, 2020 at 02:31:00PM +0200, Willy Tarreau wrote: > Hi Greg, > > On Wed, Jun 17, 2020 at 12:34:12PM +0200, Greg Kroah-Hartman wrote: > > From: Wade Mealing > > > > Turns out that the permissions for 0400 really are what we want here, > > otherwise any user can write to this file. >

Re: [PATCH] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"

2020-06-17 Thread Greg Kroah-Hartman
On Wed, Jun 17, 2020 at 01:05:54PM +0200, Steffen Maier wrote: > On 6/17/20 12:34 PM, Greg Kroah-Hartman wrote: > > From: Wade Mealing > > > > Turns out that the permissions for 0400 really are what we want here, > > otherwise any user can write to this file. > > Minor confusion on my side: >

Re: [PATCH] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"

2020-06-17 Thread Steffen Maier
On 6/17/20 12:34 PM, Greg Kroah-Hartman wrote: From: Wade Mealing Turns out that the permissions for 0400 really are what we want here, otherwise any user can write to this file. Minor confusion on my side: Did you mean "read from" instead of "write to"? I.e. only owner may read but not

[PATCH] Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"

2020-06-17 Thread Greg Kroah-Hartman
From: Wade Mealing Turns out that the permissions for 0400 really are what we want here, otherwise any user can write to this file. [fixed formatting and made static - gregkh] Reported-by: Wade Mealing Cc: stable Fixes: f40609d1591f ("zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()")