Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-09-08 Thread Stephen Smalley
On Tue, Sep 8, 2020 at 12:44 AM Lakshmi Ramasubramanian wrote: > > On 9/7/20 3:32 PM, Stephen Smalley wrote: > > >> Signed-off-by: Lakshmi Ramasubramanian > >> Suggested-by: Stephen Smalley > >> Reported-by: kernel test robot # error: implicit > >> declaration of function 'vfree' > >>

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-09-08 Thread Stephen Smalley
On Tue, Sep 8, 2020 at 8:28 AM Stephen Smalley wrote: > > On Mon, Sep 7, 2020 at 5:39 PM Lakshmi Ramasubramanian > wrote: > > > > Critical data structures of security modules are currently not measured. > > Therefore an attestation service, for instance, would not be able to > > attest whether

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-09-08 Thread Lakshmi Ramasubramanian
On 9/8/20 4:58 AM, Stephen Smalley wrote: On Tue, Sep 8, 2020 at 12:44 AM Lakshmi Ramasubramanian wrote: On 9/7/20 3:32 PM, Stephen Smalley wrote: Signed-off-by: Lakshmi Ramasubramanian Suggested-by: Stephen Smalley Reported-by: kernel test robot # error: implicit declaration of

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-09-08 Thread Stephen Smalley
On Mon, Sep 7, 2020 at 5:39 PM Lakshmi Ramasubramanian wrote: > > Critical data structures of security modules are currently not measured. > Therefore an attestation service, for instance, would not be able to > attest whether the security modules are always operating with the policies > and

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-09-08 Thread Ondrej Mosnacek
On Tue, Sep 8, 2020 at 2:37 PM Stephen Smalley wrote: > On Mon, Sep 7, 2020 at 5:39 PM Lakshmi Ramasubramanian > wrote: > > diff --git a/security/selinux/measure.c b/security/selinux/measure.c > > new file mode 100644 > > index ..caf9107937d9 > > --- /dev/null > > +++

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-09-07 Thread Lakshmi Ramasubramanian
On 9/7/20 3:32 PM, Stephen Smalley wrote: Signed-off-by: Lakshmi Ramasubramanian Suggested-by: Stephen Smalley Reported-by: kernel test robot # error: implicit declaration of function 'vfree' Reported-by: kernel test robot # error: implicit declaration of function 'crypto_alloc_shash'

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-09-07 Thread Stephen Smalley
On Mon, Sep 7, 2020 at 5:39 PM Lakshmi Ramasubramanian wrote: > > Critical data structures of security modules are currently not measured. > Therefore an attestation service, for instance, would not be able to > attest whether the security modules are always operating with the policies > and

[PATCH] SELinux: Measure state and hash of policy using IMA

2020-09-07 Thread Lakshmi Ramasubramanian
Critical data structures of security modules are currently not measured. Therefore an attestation service, for instance, would not be able to attest whether the security modules are always operating with the policies and configuration that the system administrator had setup. The policies and

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-31 Thread Lakshmi Ramasubramanian
On 8/31/20 7:47 AM, Stephen Smalley wrote: Could you please let me know when the current set of changes in SELinux next branch would be completed and be ready to take new changes? I mean, roughly - would it be a month from now or you expect that to take longer? I can't speak for Paul but

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-31 Thread Stephen Smalley
On Wed, Aug 26, 2020 at 8:51 AM Stephen Smalley wrote: > > On Tue, Aug 25, 2020 at 4:49 PM Lakshmi Ramasubramanian > wrote: > > > > On 8/24/20 3:18 PM, Paul Moore wrote: > > > > Hi Paul, > > > > > Is Ondrej's re-try approach I need to use to workaround policy reload > > > issue? > >

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-26 Thread Stephen Smalley
On Tue, Aug 25, 2020 at 4:49 PM Lakshmi Ramasubramanian wrote: > > On 8/24/20 3:18 PM, Paul Moore wrote: > > Hi Paul, > > > Is Ondrej's re-try approach I need to use to workaround policy reload > > issue? > > No, I think perhaps we should move the mutex to selinux_state instead

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-25 Thread Lakshmi Ramasubramanian
On 8/24/20 3:18 PM, Paul Moore wrote: Hi Paul, Is Ondrej's re-try approach I need to use to workaround policy reload issue? No, I think perhaps we should move the mutex to selinux_state instead of selinux_fs_info. selinux_fs_info has a pointer to selinux_state so it can then use it

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-24 Thread Paul Moore
On Mon, Aug 24, 2020 at 5:29 PM Lakshmi Ramasubramanian wrote: > On 8/24/20 1:01 PM, Ondrej Mosnacek wrote: > > On Mon, Aug 24, 2020 at 9:30 PM Stephen Smalley > > wrote: > >> On Mon, Aug 24, 2020 at 2:13 PM Lakshmi Ramasubramanian > >> wrote: > >>> On 8/24/20 7:00 AM, Stephen Smalley wrote:

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-24 Thread Lakshmi Ramasubramanian
On 8/24/20 1:01 PM, Ondrej Mosnacek wrote: On Mon, Aug 24, 2020 at 9:30 PM Stephen Smalley wrote: On Mon, Aug 24, 2020 at 2:13 PM Lakshmi Ramasubramanian wrote: On 8/24/20 7:00 AM, Stephen Smalley wrote: +int security_read_policy_kernel(struct selinux_state *state, +

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-24 Thread Ondrej Mosnacek
On Mon, Aug 24, 2020 at 9:30 PM Stephen Smalley wrote: > On Mon, Aug 24, 2020 at 2:13 PM Lakshmi Ramasubramanian > wrote: > > > > On 8/24/20 7:00 AM, Stephen Smalley wrote: > > > > >> +int security_read_policy_kernel(struct selinux_state *state, > > >> + void

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-24 Thread Stephen Smalley
On Mon, Aug 24, 2020 at 2:13 PM Lakshmi Ramasubramanian wrote: > > On 8/24/20 7:00 AM, Stephen Smalley wrote: > > >> +int security_read_policy_kernel(struct selinux_state *state, > >> + void **data, size_t *len) > >> +{ > >> + int rc; > >> + > >> + rc =

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-24 Thread Lakshmi Ramasubramanian
On 8/24/20 7:00 AM, Stephen Smalley wrote: +int security_read_policy_kernel(struct selinux_state *state, + void **data, size_t *len) +{ + int rc; + + rc = security_read_policy_len(state, len); + if (rc) + return rc; + + *data =

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-24 Thread Lakshmi Ramasubramanian
On 8/24/20 7:00 AM, Stephen Smalley wrote: On Fri, Aug 21, 2020 at 9:00 PM Lakshmi Ramasubramanian +int security_read_policy_kernel(struct selinux_state *state, + void **data, size_t *len) +{ + int rc; + + rc = security_read_policy_len(state, len);

Re: [PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-24 Thread Stephen Smalley
On Fri, Aug 21, 2020 at 9:00 PM Lakshmi Ramasubramanian wrote: > > Critical data structures of security modules are currently not measured. > Therefore an attestation service, for instance, would not be able to > attest whether the security modules are always operating with the policies > and

[PATCH] SELinux: Measure state and hash of policy using IMA

2020-08-21 Thread Lakshmi Ramasubramanian
Critical data structures of security modules are currently not measured. Therefore an attestation service, for instance, would not be able to attest whether the security modules are always operating with the policies and configuration that the system administrator had setup. The policies and