Re: [PATCH] SPCR: check bit width for the 16550 UART

2017-04-30 Thread Jon Masters
On 12/13/2016 01:20 AM, Jon Masters wrote: > On 12/07/2016 10:23 AM, Mark Salter wrote: >> If you specify a baudrate with earlycon=, the driver tries to set that >> baudrate and if you have an 8250 with some non-standard baud clock, then >> it will fail. Perhaps SPCR shouldn't pass baud option to

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-12 Thread Jon Masters
On 12/07/2016 10:23 AM, Mark Salter wrote: > On Tue, 2016-12-06 at 01:34 -0500, Jon Masters wrote: >> On 12/05/2016 10:55 PM, Duc Dang wrote: >>> On Mon, Dec 5, 2016 at 6:27 PM, Jon Masters wrote: HOWEVER while the console does come up, the use of "earlycon" on the command line (with n

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-07 Thread Mark Salter
On Tue, 2016-12-06 at 01:34 -0500, Jon Masters wrote: > On 12/05/2016 10:55 PM, Duc Dang wrote: > > > > On Mon, Dec 5, 2016 at 6:27 PM, Jon Masters wrote: > > > > > > Hi Duc, all, > > > > > > So after regenerating the initrd override (I must have fat fingered) > > > it is now detecting the corr

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-06 Thread Aleksey Makarov
Hi Jon, On 12/06/2016 01:13 PM, Jon Masters wrote: On 12/06/2016 01:53 AM, Jon Masters wrote: On 12/06/2016 01:34 AM, Jon Masters wrote: On 12/05/2016 10:55 PM, Duc Dang wrote: On Mon, Dec 5, 2016 at 6:27 PM, Jon Masters wrote: ToUUID ("daffd814-6eba-4d8c-8a91-bc9

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Jon Masters
On 12/06/2016 01:53 AM, Jon Masters wrote: > On 12/06/2016 01:34 AM, Jon Masters wrote: >> On 12/05/2016 10:55 PM, Duc Dang wrote: >>> On Mon, Dec 5, 2016 at 6:27 PM, Jon Masters wrote: > ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* > Device Properties for _DSD */,

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Jon Masters
On 12/06/2016 01:34 AM, Jon Masters wrote: > On 12/05/2016 10:55 PM, Duc Dang wrote: >> On Mon, Dec 5, 2016 at 6:27 PM, Jon Masters wrote: >>> Hi Duc, all, >>> >>> So after regenerating the initrd override (I must have fat fingered) >>> it is now detecting the correct bit width on boot (attached d

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Jon Masters
On 12/05/2016 10:55 PM, Duc Dang wrote: > On Mon, Dec 5, 2016 at 6:27 PM, Jon Masters wrote: >> Hi Duc, all, >> >> So after regenerating the initrd override (I must have fat fingered) >> it is now detecting the correct bit width on boot (attached dmesg log). >> >> HOWEVER while the console does co

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Duc Dang
On Mon, Dec 5, 2016 at 6:27 PM, Jon Masters wrote: > Hi Duc, all, > > So after regenerating the initrd override (I must have fat fingered) > it is now detecting the correct bit width on boot (attached dmesg log). > > HOWEVER while the console does come up, the use of "earlycon" on the > command li

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Jon Masters
Hi Duc, all, So after regenerating the initrd override (I must have fat fingered) it is now detecting the correct bit width on boot (attached dmesg log). HOWEVER while the console does come up, the use of "earlycon" on the command line (with no parameters) doesn't result in the early SPCR console

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Duc Dang
On Mon, Dec 5, 2016 at 3:52 PM, Duc Dang wrote: > Hi Jon, > > On Mon, Dec 5, 2016 at 3:27 PM, Jon Masters wrote: >> Duc, Aleksey, all, >> >> I have a question about this... >> >> On 12/05/2016 01:51 PM, Duc Dang wrote: >>> On Mon, Dec 5, 2016 at 5:05 AM, Aleksey Makarov >>> wrote: Check the

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Jon Masters
On 12/05/2016 06:52 PM, Duc Dang wrote: > But I am still curious why setting subtype to '0' does not work on > your board. Are you using Mustang or m400? m400 with updated tables (that are correctly overriding not appending) provided via INITRD override. I am looking at why it's not working. [

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Jon Masters
On 12/05/2016 06:52 PM, Duc Dang wrote: > Hi Jon, > > On Mon, Dec 5, 2016 at 3:27 PM, Jon Masters wrote: >> Duc, Aleksey, all, >> >> I have a question about this... >> >> On 12/05/2016 01:51 PM, Duc Dang wrote: >>> On Mon, Dec 5, 2016 at 5:05 AM, Aleksey Makarov >>> wrote: Check the 'Regist

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Duc Dang
Hi Jon, On Mon, Dec 5, 2016 at 3:27 PM, Jon Masters wrote: > Duc, Aleksey, all, > > I have a question about this... > > On 12/05/2016 01:51 PM, Duc Dang wrote: >> On Mon, Dec 5, 2016 at 5:05 AM, Aleksey Makarov >> wrote: >>> Check the 'Register Bit Width' field of the ACPI Generic Address >>> St

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Jon Masters
Duc, Aleksey, all, I have a question about this... On 12/05/2016 01:51 PM, Duc Dang wrote: > On Mon, Dec 5, 2016 at 5:05 AM, Aleksey Makarov > wrote: >> Check the 'Register Bit Width' field of the ACPI Generic Address >> Structure that specifies the address of the UART registers to >> decide if

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Duc Dang
On Mon, Dec 5, 2016 at 5:05 AM, Aleksey Makarov wrote: > Check the 'Register Bit Width' field of the ACPI Generic Address > Structure that specifies the address of the UART registers to > decide if the driver should use "mmio32" access instead of "mmio". > > If the driver is other than 16550 the a

[PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Aleksey Makarov
Check the 'Register Bit Width' field of the ACPI Generic Address Structure that specifies the address of the UART registers to decide if the driver should use "mmio32" access instead of "mmio". If the driver is other than 16550 the access with is defined by the Interface Type field of the SPCR tab