On 03/17/2014 08:00 PM, Rob Herring wrote:
> On Mon, Mar 17, 2014 at 8:22 AM, Michal Simek wrote:
>> Hi Rob,
>>
>> On 03/17/2014 01:47 PM, Rob Herring wrote:
>>> On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam wrote:
Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
On 03/17/2014 08:00 PM, Rob Herring wrote:
On Mon, Mar 17, 2014 at 8:22 AM, Michal Simek mon...@monstr.eu wrote:
Hi Rob,
On 03/17/2014 01:47 PM, Rob Herring wrote:
On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam hari...@xilinx.com wrote:
Add driver for Cadence SPI controller. This is used in
On Tue, Mar 18, 2014 at 02:45:09PM +, Harini Katakam wrote:
> OK. I dint consider interrupt sharing.
> Do you think the following implementation would be better?
> status = IRQ_NONE;
> if (intr_status & CDNS_SPI_IXR_MODF_MASK) {
> /* Handle this interrupt here */
> status =
; r...@landley.net;
> grant.lik...@linaro.org; devicet...@vger.kernel.org; linux-
> d...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> s...@vger.kernel.org; Michal Simek
> Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
>
> On Tue, Mar 18, 2014 at 12
On Tue, Mar 18, 2014 at 12:13:45PM +, Harini Katakam wrote:
> I'm going to remove the bits_per_word check anyway.
> But the clock configuration still needs to be done.
> Where should it be done spi_setup() or transfer?
It needs to be done on the transfer - that is required anyway since the
; r...@landley.net;
> grant.lik...@linaro.org; devicet...@vger.kernel.org; linux-
> d...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> s...@vger.kernel.org; Michal Simek
> Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
>
> On Tue, Mar 18, 2014 at 05:16:26AM +,
On Tue, Mar 18, 2014 at 05:22:37AM +, Harini Katakam wrote:
> > > > This needs to call spi_master_suspend() as well (and similarly on
> > > > resume).
...
> In case of a suspend, we are stopping an ongoing transfer and
> disabling the interface. In case I add clock disable and anything
>
On Tue, Mar 18, 2014 at 05:16:26AM +, Harini Katakam wrote:
Please fix your mailer to word wrap within paragraphs, this will make
your mail much more legible.
> > > + if (bits_per_word != 8) {
> > > + dev_err(>dev, "%s, unsupported bits per word %x\n",
> > > +
On Tue, Mar 18, 2014 at 05:16:26AM +, Harini Katakam wrote:
Please fix your mailer to word wrap within paragraphs, this will make
your mail much more legible.
+ if (bits_per_word != 8) {
+ dev_err(spi-dev, %s, unsupported bits per word %x\n,
+ __func__,
On Tue, Mar 18, 2014 at 05:22:37AM +, Harini Katakam wrote:
This needs to call spi_master_suspend() as well (and similarly on
resume).
...
In case of a suspend, we are stopping an ongoing transfer and
disabling the interface. In case I add clock disable and anything
else to
...@linaro.org; devicet...@vger.kernel.org; linux-
d...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
s...@vger.kernel.org; Michal Simek
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
On Tue, Mar 18, 2014 at 05:16:26AM +, Harini Katakam wrote:
Please fix your mailer
On Tue, Mar 18, 2014 at 12:13:45PM +, Harini Katakam wrote:
I'm going to remove the bits_per_word check anyway.
But the clock configuration still needs to be done.
Where should it be done spi_setup() or transfer?
It needs to be done on the transfer - that is required anyway since the
...@linaro.org; devicet...@vger.kernel.org; linux-
d...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
s...@vger.kernel.org; Michal Simek
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
On Tue, Mar 18, 2014 at 12:13:45PM +, Harini Katakam wrote:
In this case both
On Tue, Mar 18, 2014 at 02:45:09PM +, Harini Katakam wrote:
OK. I dint consider interrupt sharing.
Do you think the following implementation would be better?
status = IRQ_NONE;
if (intr_status CDNS_SPI_IXR_MODF_MASK) {
/* Handle this interrupt here */
status =
...@codeaurora.org; r...@landley.net; grant.lik...@linaro.org;
> devicet...@vger.kernel.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; linux-...@vger.kernel.org; Michal Simek
> Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
>
> On Mon, Mar 17, 2014 at 12:
; r...@landley.net;
> grant.lik...@linaro.org; devicet...@vger.kernel.org; linux-
> d...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> s...@vger.kernel.org; Michal Simek
> Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
>
> On Mon, Mar 17, 2014 at 05
On Mon, Mar 17, 2014 at 8:22 AM, Michal Simek wrote:
> Hi Rob,
>
> On 03/17/2014 01:47 PM, Rob Herring wrote:
>> On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam wrote:
>>> Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
>>>
>>> Signed-off-by: Harini Katakam
>>> ---
>>>
On Mon, Mar 17, 2014 at 12:59:11PM -0500, Josh Cartwright wrote:
> On Mon, Mar 17, 2014 at 05:30:17PM +, Mark Brown wrote:
> > On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:
> > > +static int __maybe_unused cdns_spi_suspend(struct device *dev)
> > > +{
> > This needs to call
On Mon, Mar 17, 2014 at 05:30:17PM +, Mark Brown wrote:
> On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:
[..]
> > +static int __maybe_unused cdns_spi_suspend(struct device *dev)
> > +{
>
> This needs to call spi_master_suspend() as well (and similarly on
> resume).
I'm not
On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:
> + bits_per_word = transfer ?
> + transfer->bits_per_word : spi->bits_per_word;
This would be a lot more legible without the ternery operator.
> + if (bits_per_word != 8) {
> + dev_err(>dev,
.kernel.org; linux-
> d...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> s...@vger.kernel.org; Michal Simek
> Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
>
> On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam
> wrote:
> > Add driver for Cadence S
Likely;
> devicet...@vger.kernel.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; linux-...@vger.kernel.org
> Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
>
> Hi Rob,
>
> On 03/17/2014 01:47 PM, Rob Herring wrote:
> > On Mon, Mar 17, 2014 at 7:05
On Mon, Mar 17, 2014 at 2:22 PM, Michal Simek wrote:
>>> + return 0;
>>> +}
>>> +
>>> +static SIMPLE_DEV_PM_OPS(cdns_spi_dev_pm_ops, cdns_spi_suspend,
>>> +cdns_spi_resume);
>>> +
>>> +/* Work with hotplug and coldplug */
>>> +MODULE_ALIAS("platform:" CDNS_SPI_NAME);
Hi Rob,
On 03/17/2014 01:47 PM, Rob Herring wrote:
> On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam wrote:
>> Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
>>
>> Signed-off-by: Harini Katakam
>> ---
>> .../devicetree/bindings/spi/spi-cadence.txt| 25 +
>
> We
On Mon, Mar 17, 2014 at 07:47:24AM -0500, Rob Herring wrote:
Please delete irrelevant context from your replies, it makes it easier
to find the new content.
> On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam wrote:
> > +/* Macros for the SPI controller read/write */
> > +#define
On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam wrote:
> Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
>
> Signed-off-by: Harini Katakam
> ---
> .../devicetree/bindings/spi/spi-cadence.txt| 25 +
We prefer binding docs in separate patch.
> drivers/spi/Kconfig
Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
Signed-off-by: Harini Katakam
---
.../devicetree/bindings/spi/spi-cadence.txt| 25 +
drivers/spi/Kconfig|7 +
drivers/spi/Makefile |1 +
Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
Signed-off-by: Harini Katakam hari...@xilinx.com
---
.../devicetree/bindings/spi/spi-cadence.txt| 25 +
drivers/spi/Kconfig|7 +
drivers/spi/Makefile |
On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam hari...@xilinx.com wrote:
Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
Signed-off-by: Harini Katakam hari...@xilinx.com
---
.../devicetree/bindings/spi/spi-cadence.txt| 25 +
We prefer binding docs in separate
On Mon, Mar 17, 2014 at 07:47:24AM -0500, Rob Herring wrote:
Please delete irrelevant context from your replies, it makes it easier
to find the new content.
On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam hari...@xilinx.com wrote:
+/* Macros for the SPI controller read/write */
+#define
Hi Rob,
On 03/17/2014 01:47 PM, Rob Herring wrote:
On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam hari...@xilinx.com wrote:
Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
Signed-off-by: Harini Katakam hari...@xilinx.com
---
.../devicetree/bindings/spi/spi-cadence.txt
On Mon, Mar 17, 2014 at 2:22 PM, Michal Simek mon...@monstr.eu wrote:
+ return 0;
+}
+
+static SIMPLE_DEV_PM_OPS(cdns_spi_dev_pm_ops, cdns_spi_suspend,
+cdns_spi_resume);
+
+/* Work with hotplug and coldplug */
+MODULE_ALIAS(platform: CDNS_SPI_NAME);
Not
; linux-...@vger.kernel.org; linux-
ker...@vger.kernel.org; linux-...@vger.kernel.org
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
Hi Rob,
On 03/17/2014 01:47 PM, Rob Herring wrote:
On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam hari...@xilinx.com
wrote:
Add driver
...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
s...@vger.kernel.org; Michal Simek
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam hari...@xilinx.com
wrote:
Add driver for Cadence SPI controller. This is used in Xilinx Zynq
On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:
+ bits_per_word = transfer ?
+ transfer-bits_per_word : spi-bits_per_word;
This would be a lot more legible without the ternery operator.
+ if (bits_per_word != 8) {
+ dev_err(spi-dev,
On Mon, Mar 17, 2014 at 05:30:17PM +, Mark Brown wrote:
On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:
[..]
+static int __maybe_unused cdns_spi_suspend(struct device *dev)
+{
This needs to call spi_master_suspend() as well (and similarly on
resume).
I'm not that
On Mon, Mar 17, 2014 at 12:59:11PM -0500, Josh Cartwright wrote:
On Mon, Mar 17, 2014 at 05:30:17PM +, Mark Brown wrote:
On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:
+static int __maybe_unused cdns_spi_suspend(struct device *dev)
+{
This needs to call
On Mon, Mar 17, 2014 at 8:22 AM, Michal Simek mon...@monstr.eu wrote:
Hi Rob,
On 03/17/2014 01:47 PM, Rob Herring wrote:
On Mon, Mar 17, 2014 at 7:05 AM, Harini Katakam hari...@xilinx.com wrote:
Add driver for Cadence SPI controller. This is used in Xilinx Zynq.
Signed-off-by: Harini
...@linaro.org; devicet...@vger.kernel.org; linux-
d...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
s...@vger.kernel.org; Michal Simek
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
On Mon, Mar 17, 2014 at 05:35:36PM +0530, Harini Katakam wrote:
+ bits_per_word
; grant.lik...@linaro.org;
devicet...@vger.kernel.org; linux-...@vger.kernel.org; linux-
ker...@vger.kernel.org; linux-...@vger.kernel.org; Michal Simek
Subject: Re: [PATCH] SPI: Add driver for Cadence SPI controller
On Mon, Mar 17, 2014 at 12:59:11PM -0500, Josh Cartwright wrote:
On Mon
40 matches
Mail list logo
