Re: [PATCH] Set the correct RTNL family for multicast netconf messages

2013-06-28 Thread Nicolas Dichtel
Le 28/06/2013 17:26, Stephen Hemminger a écrit : On Thu, 27 Jun 2013 16:44:47 -0700 Sven-Thorsten Dietrich wrote: There may be other cases that require a special case, so I chose the switch approach. Please note, that all other messages from ipmr[6].c correctly set the family, while these d

Re: [PATCH] Set the correct RTNL family for multicast netconf messages

2013-06-28 Thread Stephen Hemminger
On Thu, 27 Jun 2013 16:44:47 -0700 Sven-Thorsten Dietrich wrote: > There may be other cases that require a special case, so I chose the switch > approach. > > Please note, that all other messages from ipmr[6].c correctly set the family, > while these do not. > > Thanks > > Sven > > > > Su

Re: [PATCH] Set the correct RTNL family for multicast netconf messages

2013-06-28 Thread Nicolas Dichtel
Le 28/06/2013 03:51, Hannes Frederic Sowa a écrit : On Thu, Jun 27, 2013 at 06:33:42PM -0700, Stephen Hemminger wrote: On Fri, 28 Jun 2013 03:23:07 +0200 Hannes Frederic Sowa wrote: Hm, are you sure? NETCONFA_MC_FORWARDING is of type RTM_NEWNETCONF and expects ncm_family to be either AF_INET o

Re: [PATCH] Set the correct RTNL family for multicast netconf messages

2013-06-27 Thread Hannes Frederic Sowa
On Thu, Jun 27, 2013 at 06:33:42PM -0700, Stephen Hemminger wrote: > On Fri, 28 Jun 2013 03:23:07 +0200 > Hannes Frederic Sowa wrote: > > Hm, are you sure? NETCONFA_MC_FORWARDING is of type RTM_NEWNETCONF > > and expects ncm_family to be either AF_INET or AF_INET6 (at least in > > iproute2/ipmonit

Re: [PATCH] Set the correct RTNL family for multicast netconf messages

2013-06-27 Thread Stephen Hemminger
On Fri, 28 Jun 2013 03:23:07 +0200 Hannes Frederic Sowa wrote: > On Thu, Jun 27, 2013 at 04:44:47PM -0700, Sven-Thorsten Dietrich wrote: > > diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c > > index dfc39d4..695858b 100644 > > --- a/net/ipv4/devinet.c > > +++ b/net/ipv4/devinet.c > > @@ -170

Re: [PATCH] Set the correct RTNL family for multicast netconf messages

2013-06-27 Thread Hannes Frederic Sowa
On Thu, Jun 27, 2013 at 04:44:47PM -0700, Sven-Thorsten Dietrich wrote: > diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c > index dfc39d4..695858b 100644 > --- a/net/ipv4/devinet.c > +++ b/net/ipv4/devinet.c > @@ -1705,7 +1705,16 @@ static int inet_netconf_fill_devconf(struct sk_buff > *skb,

[PATCH] Set the correct RTNL family for multicast netconf messages

2013-06-27 Thread Sven-Thorsten Dietrich
There may be other cases that require a special case, so I chose the switch approach. Please note, that all other messages from ipmr[6].c correctly set the family, while these do not. Thanks Sven Subject: Set correct RTNL family for multicast netconf messages From: Sven-Thorsten Dietrich s.