Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-28 Thread Andi Kleen
On Wednesday 28 March 2007 21:18, Jeremy Fitzhardinge wrote: > Andi Kleen wrote: > > On Wednesday 28 March 2007 00:13, Jeremy Fitzhardinge wrote: > > > >> smp_call_function and smp_call_function_single are almost complete > >> duplicates of the same logic. This patch combines them by > >>

Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-28 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > On Wednesday 28 March 2007 00:13, Jeremy Fitzhardinge wrote: > >> smp_call_function and smp_call_function_single are almost complete >> duplicates of the same logic. This patch combines them by >> implementing them in terms of the more general >> smp_call_function_mask().

Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-28 Thread Andi Kleen
On Wednesday 28 March 2007 00:13, Jeremy Fitzhardinge wrote: > smp_call_function and smp_call_function_single are almost complete > duplicates of the same logic. This patch combines them by > implementing them in terms of the more general > smp_call_function_mask(). I think I got those already.

Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-28 Thread Andi Kleen
On Wednesday 28 March 2007 00:13, Jeremy Fitzhardinge wrote: smp_call_function and smp_call_function_single are almost complete duplicates of the same logic. This patch combines them by implementing them in terms of the more general smp_call_function_mask(). I think I got those already.

Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-28 Thread Jeremy Fitzhardinge
Andi Kleen wrote: On Wednesday 28 March 2007 00:13, Jeremy Fitzhardinge wrote: smp_call_function and smp_call_function_single are almost complete duplicates of the same logic. This patch combines them by implementing them in terms of the more general smp_call_function_mask(). I

Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-28 Thread Andi Kleen
On Wednesday 28 March 2007 21:18, Jeremy Fitzhardinge wrote: Andi Kleen wrote: On Wednesday 28 March 2007 00:13, Jeremy Fitzhardinge wrote: smp_call_function and smp_call_function_single are almost complete duplicates of the same logic. This patch combines them by implementing them

Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-27 Thread Jeremy Fitzhardinge
Randy Dunlap wrote: > func() or ?? > and what does "nearly ready" mean? > Sorry, I forgot to include your doc updates from last time. "nearly ready" means that its just about to call the function, but hasn't necessarily done so. J - To

Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-27 Thread Randy Dunlap
On Tue, 27 Mar 2007 15:13:29 -0700 Jeremy Fitzhardinge wrote: > smp_call_function and smp_call_function_single are almost complete > duplicates of the same logic. This patch combines them by > implementing them in terms of the more general > smp_call_function_mask(). > > [ Jan, Andi: This only

[PATCH] Simplify smp_call_function*() by using common implementation

2007-03-27 Thread Jeremy Fitzhardinge
smp_call_function and smp_call_function_single are almost complete duplicates of the same logic. This patch combines them by implementing them in terms of the more general smp_call_function_mask(). [ Jan, Andi: This only changes arch/i386; can x86_64 be changed in the same way? ] [ Rebased

[PATCH] Simplify smp_call_function*() by using common implementation

2007-03-27 Thread Jeremy Fitzhardinge
smp_call_function and smp_call_function_single are almost complete duplicates of the same logic. This patch combines them by implementing them in terms of the more general smp_call_function_mask(). [ Jan, Andi: This only changes arch/i386; can x86_64 be changed in the same way? ] [ Rebased

Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-27 Thread Randy Dunlap
On Tue, 27 Mar 2007 15:13:29 -0700 Jeremy Fitzhardinge wrote: smp_call_function and smp_call_function_single are almost complete duplicates of the same logic. This patch combines them by implementing them in terms of the more general smp_call_function_mask(). [ Jan, Andi: This only

Re: [PATCH] Simplify smp_call_function*() by using common implementation

2007-03-27 Thread Jeremy Fitzhardinge
Randy Dunlap wrote: func() or what?? and what does nearly ready mean? Sorry, I forgot to include your doc updates from last time. nearly ready means that its just about to call the function, but hasn't necessarily done so. J - To