Re: [PATCH] Simplify some code to use the container_of() macro.

2007-01-04 Thread Robert P. J. Day
On Thu, 4 Jan 2007, Thomas Hisch wrote: > On Sun, Dec 31, 2006 at 03:55:22PM -0500, Robert P. J. Day wrote: > > @@ -1810,8 +1809,7 @@ lcs_get_frames_cb(struct lcs_channel *channel, struct > > lcs_buffer *buffer) > > LCS_DBF_TEXT(4, trace, "-eiogpkt"); > > return; > > }

Re: [PATCH] Simplify some code to use the container_of() macro.

2007-01-04 Thread Thomas Hisch
On Sun, Dec 31, 2006 at 03:55:22PM -0500, Robert P. J. Day wrote: > @@ -1810,8 +1809,7 @@ lcs_get_frames_cb(struct lcs_channel *channel, struct > lcs_buffer *buffer) > LCS_DBF_TEXT(4, trace, "-eiogpkt"); > return; > } > - card = (struct lcs_card *) > -

Re: [PATCH] Simplify some code to use the container_of() macro.

2007-01-04 Thread Robert P. J. Day
On Wed, 3 Jan 2007, Andrew Morton wrote: > On Sun, 31 Dec 2006 15:55:22 -0500 (EST) > "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > > --- a/net/ipv4/netfilter/nf_nat_core.c > > +++ b/net/ipv4/netfilter/nf_nat_core.c > > @@ -168,7 +168,7 @@ find_appropriate_src(const struct nf_conntrack_tuple

Re: [PATCH] Simplify some code to use the container_of() macro.

2007-01-03 Thread Robert P. J. Day
On Wed, 3 Jan 2007, Andrew Morton wrote: > On Sun, 31 Dec 2006 15:55:22 -0500 (EST) > "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > > --- a/net/ipv4/netfilter/nf_nat_core.c > > +++ b/net/ipv4/netfilter/nf_nat_core.c > > @@ -168,7 +168,7 @@ find_appropriate_src(const struct nf_conntrack_tuple

Re: [PATCH] Simplify some code to use the container_of() macro.

2007-01-03 Thread Andrew Morton
On Sun, 31 Dec 2006 15:55:22 -0500 (EST) "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > --- a/net/ipv4/netfilter/nf_nat_core.c > +++ b/net/ipv4/netfilter/nf_nat_core.c > @@ -168,7 +168,7 @@ find_appropriate_src(const struct nf_conntrack_tuple > *tuple, > > read_lock_bh(&nf_nat_lock); >

[PATCH] Simplify some code to use the container_of() macro.

2006-12-31 Thread Robert P. J. Day
Simplify a number of code snippets in source and header files to use the kernel.h "container_of()" macro. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- and while we're at it, everybody can stop re-inventing the container_of() macro. :-) drivers/net/ppp_generic.c|2