Re: [PATCH] Some love to default profiler

2007-07-10 Thread Matt Mackall
On Thu, Jul 05, 2007 at 01:34:20AM +0400, Alexey Dobriyan wrote: > 1) Drop __KERNEL__ out of profile.h. It contains only internal kernel stuff > and >not in exported headers list > 2) Put profile.c under CONFIG_PROFILING. You enabled profiling in config, you >will get it. Removes condition

Re: [PATCH] Some love to default profiler

2007-07-08 Thread Jesper Juhl
On 08/07/07, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Thu, Jul 05, 2007 at 01:50:27AM +0200, Jesper Juhl wrote: > On 04/07/07, Alexey Dobriyan <[EMAIL PROTECTED]> wrote: >> 1) Drop __KERNEL__ out of profile.h. It contains only internal kernel >> stuff and >>not in exported headers list > > E

Re: [PATCH] Some love to default profiler

2007-07-08 Thread Adrian Bunk
On Thu, Jul 05, 2007 at 01:50:27AM +0200, Jesper Juhl wrote: > On 04/07/07, Alexey Dobriyan <[EMAIL PROTECTED]> wrote: >> 1) Drop __KERNEL__ out of profile.h. It contains only internal kernel >> stuff and >>not in exported headers list > > Even if it's not in the list of exported headers, does

Re: [PATCH] Some love to default profiler

2007-07-06 Thread Alexey Dobriyan
On Thu, Jul 05, 2007 at 01:50:27AM +0200, Jesper Juhl wrote: > One tiny comment below. > >+#define prof_on 0 > >+static inline void profile_init(void) > >+{ > >+} > > Just to be pedantic; don't we want a blank line between functions > here, even if they are empty? Dunno, it's boilerplate code, no

Re: [PATCH] Some love to default profiler

2007-07-05 Thread Robert P. J. Day
On Thu, 5 Jul 2007, Denis Vlasenko wrote: > On Thursday 05 July 2007 01:50, Jesper Juhl wrote: > > > Removes conditional branch from schedule(). Code savings on my > > >usual config: > > > > > >textdata bss dec hex filename > > > 2921871 179895 180224 3281

Re: [PATCH] Some love to default profiler

2007-07-05 Thread Denis Vlasenko
On Thursday 05 July 2007 01:50, Jesper Juhl wrote: > > Removes conditional branch from schedule(). Code savings on my > >usual config: > > > >textdata bss dec hex filename > > 2921871 179895 180224 3281990 321446 vmlinux before > > 2920141

Re: [PATCH] Some love to default profiler

2007-07-04 Thread Jesper Juhl
On 04/07/07, Alexey Dobriyan <[EMAIL PROTECTED]> wrote: 1) Drop __KERNEL__ out of profile.h. It contains only internal kernel stuff and not in exported headers list Even if it's not in the list of exported headers, does it really hurt to retain that extra safeguard? 2) Put profile.c under

Re: [PATCH] Some love to default profiler

2007-07-04 Thread Andi Kleen
Alexey Dobriyan <[EMAIL PROTECTED]> writes: > 2) Put profile.c under CONFIG_PROFILING. You enabled profiling in config, you >will get it. Removes conditional branch from schedule(). Code savings on my >usual config: > > textdata bss dec hex filename > 292187

[PATCH] Some love to default profiler

2007-07-04 Thread Alexey Dobriyan
1) Drop __KERNEL__ out of profile.h. It contains only internal kernel stuff and not in exported headers list 2) Put profile.c under CONFIG_PROFILING. You enabled profiling in config, you will get it. Removes conditional branch from schedule(). Code savings on my usual config: t