Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

2014-05-25 Thread Joe Perches
On Sun, 2014-05-25 at 21:58 -0700, Chaitanya Hazarey wrote: > Added a blank line after declarations in many places to fix > the following warning issued by checkpatch.pl: Unrelated trivial note: > diff --git a/drivers/staging/silicom/bpctl_mod.c > b/drivers/staging/silicom/bpctl_mod.c > @@

[PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

2014-05-25 Thread Chaitanya Hazarey
Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey --- drivers/staging/silicom/bpctl_mod.c| 88 +++-

Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

2014-05-25 Thread Chaitanya Hazarey
On its way. Chaitanya On Sun, May 25, 2014 at 5:51 PM, Greg KH wrote: > On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote: >> Added a blank line after declarations in many places to fix the following >> warning issued by checkpatch.pl: > > Always wrap your lines at 72 columns,

Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

2014-05-25 Thread Greg KH
On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote: > Added a blank line after declarations in many places to fix the following > warning issued by checkpatch.pl: Always wrap your lines at 72 columns, like git asks you to when you type in the commit message. > WARNING: Missing a

[PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

2014-05-25 Thread Chaitanya Hazarey
Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations The reason why it was not applying clean against Greg's tree was that bpctl_mod.c had changed in the functions which are a part of this

[PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

2014-05-25 Thread Chaitanya Hazarey
Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations The reason why it was not applying clean against Greg's tree was that bpctl_mod.c had changed in the functions which are a part of this

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

2014-05-25 Thread Greg KH
On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: Always wrap your lines at 72 columns, like git asks you to when you type in the commit message. WARNING: Missing a

[PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

2014-05-25 Thread Chaitanya Hazarey
Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/silicom/bpctl_mod.c| 88 +++-

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

2014-05-25 Thread Chaitanya Hazarey
On its way. Chaitanya On Sun, May 25, 2014 at 5:51 PM, Greg KH gre...@linuxfoundation.org wrote: On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: Always wrap your

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

2014-05-25 Thread Joe Perches
On Sun, 2014-05-25 at 21:58 -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: Unrelated trivial note: diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c @@ -2802,6