Re: [PATCH] Staging: android: fix coding style warning

2016-08-15 Thread Greg KH
On Sun, May 22, 2016 at 10:52:15PM -0500, Jaime Arrocha wrote: > From: Jaime Arrocha > > Fixed checkpatch.pl warning about 'line over 80 characters'. > > Signed-off-by: Jaime Arrocha > --- > drivers/staging/android/ion/ion.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Someon

[PATCH] Staging: android: fix coding style warning

2016-05-22 Thread Jaime Arrocha
From: Jaime Arrocha Fixed checkpatch.pl warning about 'line over 80 characters'. Signed-off-by: Jaime Arrocha --- drivers/staging/android/ion/ion.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c i

Re: [PATCH] Staging: android: fix coding style and TODO file

2015-07-01 Thread Sohny Thomas
On Wednesday 01 July 2015 05:59 PM, Frans Klaver wrote: > On Wed, Jul 1, 2015 at 2:22 PM, Sohny Thomas wrote: >> >> >> On Wednesday 01 July 2015 05:37 PM, Frans Klaver wrote: >>> On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas wrote: - removed non-existant issue from TODO file >>> >>> s,exist

Re: [PATCH] Staging: android: fix coding style and TODO file

2015-07-01 Thread Frans Klaver
On Wed, Jul 1, 2015 at 2:22 PM, Sohny Thomas wrote: > > > On Wednesday 01 July 2015 05:37 PM, Frans Klaver wrote: >> On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas wrote: >>> - removed non-existant issue from TODO file >> >> s,existant,existent, > Thanks missed that >> >>> kuid_t or uid_t not prese

Re: [PATCH] Staging: android: fix coding style and TODO file

2015-07-01 Thread Sohny Thomas
On Wednesday 01 July 2015 05:37 PM, Frans Klaver wrote: > On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas wrote: >> - removed non-existant issue from TODO file > > s,existant,existent, Thanks missed that > >> kuid_t or uid_t not present in staging/android >> - fixed 80 char limit exceeding line >

Re: [PATCH] Staging: android: fix coding style and TODO file

2015-07-01 Thread Sudip Mukherjee
On Wed, Jul 01, 2015 at 02:07:05PM +0200, Frans Klaver wrote: > On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas wrote: > > - removed non-existant issue from TODO file > > s,existant,existent, > > > kuid_t or uid_t not present in staging/android > > - fixed 80 char limit exceeding line > > - a newli

Re: [PATCH] Staging: android: fix coding style and TODO file

2015-07-01 Thread Frans Klaver
On Wed, Jul 1, 2015 at 1:56 PM, Sohny Thomas wrote: > - removed non-existant issue from TODO file s,existant,existent, > kuid_t or uid_t not present in staging/android > - fixed 80 char limit exceeding line > - a newline after decelartions as per checkpatch.pl > - fixed an unnecessary typedef as

[PATCH] Staging: android: fix coding style and TODO file

2015-07-01 Thread Sohny Thomas
- removed non-existant issue from TODO file kuid_t or uid_t not present in staging/android - fixed 80 char limit exceeding line - a newline after decelartions as per checkpatch.pl - fixed an unnecessary typedef as reported by checkpatch.pl --- drivers/staging/android/TODO | 7 ---

Re: [PATCH] staging: android: fix coding style error (v2)

2015-01-14 Thread Patrick Boettcher
Hi Dan, Thanks for your valuable input. It's appreciated. On Wed, 14 Jan 2015 12:28:44 +0300 Dan Carpenter wrote: > > lots of Cc:'s [..] > > This block is not needed. This is a whitespace patch not something > controversial where we will need to look at who was CC'd so that we > can get annoye

Re: [PATCH] staging: android: fix coding style error (v2)

2015-01-14 Thread Dan Carpenter
Put the v2 in "[PATCH v2]" so that it gets removed and not stored in the permanent changelog. On Wed, Jan 14, 2015 at 10:10:36AM +0100, Patrick Boettcher wrote: > Simple style fix - 80 char limit was exceeded. > > This is second version of the patch. Thanks Joe Perches. Put this line under the -

[PATCH] staging: android: fix coding style error (v2)

2015-01-14 Thread Patrick Boettcher
Simple style fix - 80 char limit was exceeded. This is second version of the patch. Thanks Joe Perches. Context: eudyptula challenge (http://eudyptula-challenge.org/) Signed-off-by: Patrick Boettcher Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: John Stultz Cc: Peter Senna Tschudin Cc: Dani

Re: [PATCH] staging: android: fix coding style error

2015-01-14 Thread Joe Perches
On Wed, 2015-01-14 at 09:32 +0100, Arnd Bergmann wrote: > On Wednesday 14 January 2015 09:20:42 Patrick Boettcher wrote: > > diff --git a/drivers/staging/android/sync_debug.c > > b/drivers/staging/android/sync_debug.c [] > > @@ -96,7 +96,8 @@ static void sync_print_pt(struct seq_file *s, struct >

Re: [PATCH] staging: android: fix coding style error

2015-01-14 Thread Arnd Bergmann
On Wednesday 14 January 2015 09:20:42 Patrick Boettcher wrote: > diff --git a/drivers/staging/android/sync_debug.c > b/drivers/staging/android/sync_debug.c > index 1532a86..9a2aaf8 100644 > --- a/drivers/staging/android/sync_debug.c > +++ b/drivers/staging/android/sync_debug.c > @@ -96,7 +96,8 @@

[PATCH] staging: android: fix coding style error

2015-01-14 Thread Patrick Boettcher
Simple style fix - 80 char limit was exceeded. Context: eudyptula challenge (http://eudyptula-challenge.org/) Signed-off-by: Patrick Boettcher Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: John Stultz Cc: Peter Senna Tschudin Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Tapasweni Pathak Cc

[PATCH] Staging: android: fix coding style

2014-09-13 Thread Sorin Facaoaru
- add line after declaration Signed-off-by: Sorin Facaoaru --- drivers/staging/android/sync.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index e7b2e02..0d37495 100644 --- a/drivers/staging/android/sync.c +++ b/drivers/stagi

[PATCH] Staging: android: fix coding style

2014-09-13 Thread Sorin Facaoaru
- add line after declaration Signed-off-by: Sorin Facaoaru --- drivers/staging/android/sw_sync.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index a76db3f..863d4b1 100644 --- a/drivers/staging/android/sw_sync.c +++

Re: [PATCH] Staging: android: fix coding style issue in timed_gpio.c

2014-05-07 Thread Dan Carpenter
On Wed, May 07, 2014 at 07:23:33AM +0100, John Church wrote: > This patch fixes a coding style issue. It modifies a single line > that was over 80 characters long. > > Thanks, > John > Signed-off-by: John Church This patch isn't sent in the correct way. Use git send-email or read Documentation

Re: [PATCH] Staging: android: fix coding style issue for Eudyptula Challenge in timed_gpio.c

2014-05-06 Thread Greg KH
On Wed, May 07, 2014 at 12:44:31AM +0100, John Church wrote: > > Signed-off-by: John Church What coding style issue? You need to be specific in your body of your email, and put a blank line after the signed-off-by and before the patch, otherwise the tools can complain. And drop the Eudyptula

Re: [PATCH] staging: android: fix coding style

2014-03-14 Thread Greg KH
On Thu, Mar 13, 2014 at 10:44:55AM +0100, mo...@2600fr.org wrote: > From: mourn > > Signed-off-by: mourn As said in the thread for your other thread, this patch can't be accepted unless you use your real name, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH] staging: android: fix coding style

2014-03-14 Thread Greg KH
On Thu, Mar 13, 2014 at 03:13:04PM +0100, mourn wrote: > > > The changes look good, however you should be a bit more specific about > > what the > > fixes are, and that you used checkpatch.pl to find them (I assume). > > > > Yes, you are right. I can edit the commit log. > > > Also, Signed-off-b

Re: [PATCH] staging: android: fix coding style

2014-03-13 Thread mourn
> The changes look good, however you should be a bit more specific about > what the > fixes are, and that you used checkpatch.pl to find them (I assume). > Yes, you are right. I can edit the commit log. > Also, Signed-off-by: should state your full name, which I'm also assuming > isn't > 'mourn'

Re: [PATCH] staging: android: fix coding style

2014-03-13 Thread Mark Einon
I'll try that again... On Thu, Mar 13, 2014 at 01:50:47PM +, Mark Einon wrote: > On Thu, Mar 13, 2014 at 10:44:55AM +0100, mo...@2600fr.org wrote: > > From: mourn > > > > Signed-off-by: mourn > > --- > > drivers/staging/android/uapi/ion.h | 12 ++-- > > 1 file changed, 6 insertio

Re: [PATCH] staging: android: fix coding style

2014-03-13 Thread Mark Einon
On Thu, Mar 13, 2014 at 10:44:55AM +0100, mo...@2600fr.org wrote: > From: mourn > > Signed-off-by: mourn > --- > drivers/staging/android/uapi/ion.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) The changes look good, however you should be a bit more specific about whic

[PATCH] staging: android: fix coding style

2014-03-13 Thread mourn
From: mourn Signed-off-by: mourn --- drivers/staging/android/uapi/ion.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h index f09e7c1..6aa4956 100644 --- a/drivers/staging/android/uapi/io