Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-11 Thread Greg KH
On Mon, Nov 04, 2013 at 01:32:20PM +0100, Ondrej Zary wrote: > > Shouldn't this be removed from the code, converted to a binary file and > loaded > by the kernel firmware loader instead? Yes it should, please send patches to do so. And don't quote the whole firmware blob when responding to pat

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2013 at 01:32:20PM +0100, Ondrej Zary wrote: > > Shouldn't this be removed from the code, converted to a binary file and > loaded > by the kernel firmware loader instead? I have no idea. We may as well apply this and do that later unless someone wants to jump on it before 3.13-

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Ondrej Zary
On Monday 04 November 2013, Aldo Iljazi wrote: > Fixed the following styling issues: > > Line 30: > Removed space before open square bracket '[' > > Lines 31 to 155: > Moved the commas that were in the start of the lines, to the end of the > lines. Inserted spaces after the commas. > Inserted a one

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Dan Carpenter wrote: > On Mon, Nov 04, 2013 at 02:15:22PM +0200, Aldo Iljazi wrote: > > Fixed the following styling issues: > > > > Line 30: > > Removed space before open square bracket '[' > > > > Lines 31 to 155: > > Moved the commas that were in the start of the lines, to the end of the > >

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2013 at 02:15:22PM +0200, Aldo Iljazi wrote: > Fixed the following styling issues: > > Line 30: > Removed space before open square bracket '[' > > Lines 31 to 155: > Moved the commas that were in the start of the lines, to the end of the lines. > Inserted spaces after the commas.

[PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Fixed the following styling issues: Line 30: Removed space before open square bracket '[' Lines 31 to 155: Moved the commas that were in the start of the lines, to the end of the lines. Inserted spaces after the commas. Inserted a one tab indentation to each line. Signed-off-by: Aldo Iljazi ---

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2013 at 10:40:36AM +0200, Aldo Iljazi wrote: > Dan Carpenter wrote: > > > On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > > > Dan Carpenter wrote: > > > > > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > > > > Fixed a few styling issues, spec

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Dan Carpenter wrote: > On Mon, Nov 04, 2013 at 10:40:36AM +0200, Aldo Iljazi wrote: > > Dan Carpenter wrote: > > > > > On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > > > > Dan Carpenter wrote: > > > > > > > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > >

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Dan Carpenter wrote: > On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > > Dan Carpenter wrote: > > > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > > > Fixed a few styling issues, specifically: > > > > > > > > > > Gar... No one wants to read that changelog

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Dan Carpenter
On Mon, Nov 04, 2013 at 10:17:04AM +0200, Aldo Iljazi wrote: > Dan Carpenter wrote: > > > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > > Fixed a few styling issues, specifically: > > > > > > > Gar... No one wants to read that changelog. That was over 700 lines > > of repea

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-04 Thread Aldo Iljazi
Dan Carpenter wrote: > On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > > Fixed a few styling issues, specifically: > > > > Gar... No one wants to read that changelog. That was over 700 lines > of repeated text. > > regards, > dan carpenter > > > You are right. I'll be care

Re: [PATCH] Staging: ft1000: fixed a few styling issues

2013-11-03 Thread Dan Carpenter
On Sun, Nov 03, 2013 at 04:20:38PM +0200, Aldo Iljazi wrote: > Fixed a few styling issues, specifically: > Gar... No one wants to read that changelog. That was over 700 lines of repeated text. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

[PATCH] Staging: ft1000: fixed a few styling issues

2013-11-03 Thread Aldo Iljazi
Fixed a few styling issues, specifically: boot.h:30: ERROR: space prohibited before open square bracket '[' boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR: space required after that ',' (ctx:VxV) boot.h:31: ERROR