Re: [PATCH] Staging: iio: adc: fix macro and sysfs files modes in ad7280a.c

2016-11-27 Thread Jonathan Cameron
On 27/11/16 08:37, Boyan Vladinov wrote: > Fixes warnings found by checkpatch.pl: > - AD7280A_DEVADDR macro to use typeof, because of possible side effects Such as? I can't tell from this description whether this is a bug, or just some good coding practice stuff. > - sysfs entries user/group modes

[PATCH] Staging: iio: adc: fix macro and sysfs files modes in ad7280a.c

2016-11-27 Thread Boyan Vladinov
Fixes warnings found by checkpatch.pl: - AD7280A_DEVADDR macro to use typeof, because of possible side effects - sysfs entries user/group modes to use their octal representation - coding style (open parenthesis alignment, CamelCase...) Signed-off-by: Boyan Vladinov --- drivers/staging/iio/adc/ad