Re: [PATCH] Staging: iio: meter: Use devm functions

2015-10-04 Thread Jonathan Cameron
On 04/10/15 13:43, Shraddha Barke wrote: > > > On Sun, 4 Oct 2015, Jonathan Cameron wrote: > >> On 04/10/15 05:34, Shraddha Barke wrote: >>> Introduce use of managed resource function devm_iio_trigger_alloc >>> instead of iio_trigger_alloc and devm_request_irq instead of request_irq >>> Remove

Re: [PATCH] Staging: iio: meter: Use devm functions

2015-10-04 Thread Shraddha Barke
On Sun, 4 Oct 2015, Jonathan Cameron wrote: On 04/10/15 05:34, Shraddha Barke wrote: Introduce use of managed resource function devm_iio_trigger_alloc instead of iio_trigger_alloc and devm_request_irq instead of request_irq Remove corresponding calls to iio_trigger_free and free_irq in the

Re: [PATCH] Staging: iio: meter: Use devm functions

2015-10-04 Thread Jonathan Cameron
On 04/10/15 05:34, Shraddha Barke wrote: > Introduce use of managed resource function devm_iio_trigger_alloc > instead of iio_trigger_alloc and devm_request_irq instead of request_irq > Remove corresponding calls to iio_trigger_free and free_irq in the probe > and remove functions. > The now

Re: [PATCH] Staging: iio: meter: Use devm functions

2015-10-04 Thread Lars-Peter Clausen
On 10/04/2015 06:34 AM, Shraddha Barke wrote: > [...] Hi, Thanks for the patch. > - st->trig = iio_trigger_alloc("%s-dev%d", > - spi_get_device_id(st->us)->name, > - indio_dev->id); > + st->trig =

Re: [PATCH] Staging: iio: meter: Use devm functions

2015-10-04 Thread Lars-Peter Clausen
On 10/04/2015 06:34 AM, Shraddha Barke wrote: > [...] Hi, Thanks for the patch. > - st->trig = iio_trigger_alloc("%s-dev%d", > - spi_get_device_id(st->us)->name, > - indio_dev->id); > + st->trig =

Re: [PATCH] Staging: iio: meter: Use devm functions

2015-10-04 Thread Jonathan Cameron
On 04/10/15 05:34, Shraddha Barke wrote: > Introduce use of managed resource function devm_iio_trigger_alloc > instead of iio_trigger_alloc and devm_request_irq instead of request_irq > Remove corresponding calls to iio_trigger_free and free_irq in the probe > and remove functions. > The now

Re: [PATCH] Staging: iio: meter: Use devm functions

2015-10-04 Thread Shraddha Barke
On Sun, 4 Oct 2015, Jonathan Cameron wrote: On 04/10/15 05:34, Shraddha Barke wrote: Introduce use of managed resource function devm_iio_trigger_alloc instead of iio_trigger_alloc and devm_request_irq instead of request_irq Remove corresponding calls to iio_trigger_free and free_irq in the

Re: [PATCH] Staging: iio: meter: Use devm functions

2015-10-04 Thread Jonathan Cameron
On 04/10/15 13:43, Shraddha Barke wrote: > > > On Sun, 4 Oct 2015, Jonathan Cameron wrote: > >> On 04/10/15 05:34, Shraddha Barke wrote: >>> Introduce use of managed resource function devm_iio_trigger_alloc >>> instead of iio_trigger_alloc and devm_request_irq instead of request_irq >>> Remove

[PATCH] Staging: iio: meter: Use devm functions

2015-10-03 Thread Shraddha Barke
Introduce use of managed resource function devm_iio_trigger_alloc instead of iio_trigger_alloc and devm_request_irq instead of request_irq Remove corresponding calls to iio_trigger_free and free_irq in the probe and remove functions. The now unnecessary labels error_free_trig and err_free_irq are

[PATCH] Staging: iio: meter: Use devm functions

2015-10-03 Thread Shraddha Barke
Introduce use of managed resource function devm_iio_trigger_alloc instead of iio_trigger_alloc and devm_request_irq instead of request_irq Remove corresponding calls to iio_trigger_free and free_irq in the probe and remove functions. The now unnecessary labels error_free_trig and err_free_irq are