Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-31 Thread Laurent Pinchart
On Tuesday 31 Jan 2017 12:42:51 Sakari Ailus wrote: > On Mon, Jan 30, 2017 at 07:47:40PM +0200, Laurent Pinchart wrote: > > > @@ -678,8 +679,8 @@ iss_video_get_selection(struct file *file, void *fh, > > > struct v4l2_selection *sel) if (subdev == NULL) > > > > > > return -EINVAL; > > >

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-31 Thread Laurent Pinchart
On Tuesday 31 Jan 2017 12:42:51 Sakari Ailus wrote: > On Mon, Jan 30, 2017 at 07:47:40PM +0200, Laurent Pinchart wrote: > > > @@ -678,8 +679,8 @@ iss_video_get_selection(struct file *file, void *fh, > > > struct v4l2_selection *sel) if (subdev == NULL) > > > > > > return -EINVAL; > > >

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-31 Thread Sakari Ailus
On Mon, Jan 30, 2017 at 07:47:40PM +0200, Laurent Pinchart wrote: > > @@ -678,8 +679,8 @@ iss_video_get_selection(struct file *file, void *fh, > > struct v4l2_selection *sel) if (subdev == NULL) > > return -EINVAL; > > > > - /* Try the get selection operation first and fallback to

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-31 Thread Sakari Ailus
On Mon, Jan 30, 2017 at 07:47:40PM +0200, Laurent Pinchart wrote: > > @@ -678,8 +679,8 @@ iss_video_get_selection(struct file *file, void *fh, > > struct v4l2_selection *sel) if (subdev == NULL) > > return -EINVAL; > > > > - /* Try the get selection operation first and fallback to

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-30 Thread Laurent Pinchart
Hello Avraham, Thank you for the patch. On Saturday 28 Jan 2017 20:00:08 Avraham Shukron wrote: > This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c > Specifically, it fixes "line over 80 characters" issues > > Signed-off-by: Avraham Shukron

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-30 Thread Laurent Pinchart
Hello Avraham, Thank you for the patch. On Saturday 28 Jan 2017 20:00:08 Avraham Shukron wrote: > This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c > Specifically, it fixes "line over 80 characters" issues > > Signed-off-by: Avraham Shukron This looks OK to me. I've

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-29 Thread Avraham Shukron
On 29/01/2017 9:31, Ozgur Karatas wrote: > > > 28.01.2017, 20:11, "Avraham Shukron" : >> This is a patch that fixes issues in omap4iss/iss_video.c >> Specifically, it fixes "line over 80 characters" issues > > Hello, > > are you have a sent this changes patch before?

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-29 Thread Avraham Shukron
On 29/01/2017 9:31, Ozgur Karatas wrote: > > > 28.01.2017, 20:11, "Avraham Shukron" : >> This is a patch that fixes issues in omap4iss/iss_video.c >> Specifically, it fixes "line over 80 characters" issues > > Hello, > > are you have a sent this changes patch before? > And Greg KH answered

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-28 Thread Ozgur Karatas
28.01.2017, 20:11, "Avraham Shukron" : > This is a patch that fixes issues in omap4iss/iss_video.c > Specifically, it fixes "line over 80 characters" issues Hello, are you have a sent this changes patch before? And Greg KH answered you, are you read? Please send the

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-28 Thread Ozgur Karatas
28.01.2017, 20:11, "Avraham Shukron" : > This is a patch that fixes issues in omap4iss/iss_video.c > Specifically, it fixes "line over 80 characters" issues Hello, are you have a sent this changes patch before? And Greg KH answered you, are you read? Please send the change once, there is no

[PATCH] Staging: omap4iss: fix coding style issues

2017-01-28 Thread Avraham Shukron
This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c Specifically, it fixes "line over 80 characters" issues Signed-off-by: Avraham Shukron --- drivers/staging/media/omap4iss/iss_video.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)

[PATCH] Staging: omap4iss: fix coding style issues

2017-01-28 Thread Avraham Shukron
This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c Specifically, it fixes "line over 80 characters" issues Signed-off-by: Avraham Shukron --- drivers/staging/media/omap4iss/iss_video.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] Staging: omap4iss: fix coding style issues. This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c Specifically, it fixes "line over 80 characters" issues.

2017-01-28 Thread Greg KH
On Sat, Jan 28, 2017 at 05:59:43PM +0200, Avraham Shukron wrote: > --- > drivers/staging/media/omap4iss/iss_video.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) That's a crazy subject line :( Please fix...

Re: [PATCH] Staging: omap4iss: fix coding style issues. This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c Specifically, it fixes "line over 80 characters" issues.

2017-01-28 Thread Greg KH
On Sat, Jan 28, 2017 at 05:59:43PM +0200, Avraham Shukron wrote: > --- > drivers/staging/media/omap4iss/iss_video.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) That's a crazy subject line :( Please fix...

[PATCH] Staging: omap4iss: fix coding style issues. This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c Specifically, it fixes "line over 80 characters" issues.

2017-01-28 Thread Avraham Shukron
--- drivers/staging/media/omap4iss/iss_video.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c index c16927a..cdab053 100644 --- a/drivers/staging/media/omap4iss/iss_video.c +++

[PATCH] Staging: omap4iss: fix coding style issues. This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c Specifically, it fixes "line over 80 characters" issues.

2017-01-28 Thread Avraham Shukron
--- drivers/staging/media/omap4iss/iss_video.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c index c16927a..cdab053 100644 --- a/drivers/staging/media/omap4iss/iss_video.c +++