Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Hi, 2014-05-28 5:28 GMT+09:00 Chaitanya Hazarey : > Hey DaeSeok, > > I fixed all of them except - > > this "if" condition like below: > if (5 == wrqu->encoding.length || 13 == wrqu->encoding.length) > mask = 0x00; > and this should be outside "for" loop > > Can you please elaborate on this?

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Hey DaeSeok, I fixed all of them except - this "if" condition like below: if (5 == wrqu->encoding.length || 13 == wrqu->encoding.length) mask = 0x00; and this should be outside "for" loop Can you please elaborate on this? Thanks, Chaitanya On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Hey there, Thanks for looking into this, Will be sending out the modified version soon. Thanks, Chaitanya On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn wrote: > Hi, > > 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey : >> Fixed the following: >> >> ERROR: do not use C99 // comments >> ERROR:

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Hi, 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey : > Fixed the following: > > ERROR: do not use C99 // comments > ERROR: else should follow close brace '}' > ERROR: need consistent spacing around '*' (ctx:WxV) > ERROR: need consistent spacing around '|' (ctx:VxW) > ERROR: space prohibited after

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c r8192U_wx.c fix checkpatch.pl errors and warnings

Hi, 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey c...@24.io: Fixed the following: ERROR: do not use C99 // comments ERROR: else should follow close brace '}' ERROR: need consistent spacing around '*' (ctx:WxV) ERROR: need consistent spacing around '|' (ctx:VxW) ERROR: space prohibited

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c r8192U_wx.c fix checkpatch.pl errors and warnings

Hey there, Thanks for looking into this, Will be sending out the modified version soon. Thanks, Chaitanya On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn daeseok.y...@gmail.com wrote: Hi, 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey c...@24.io: Fixed the following: ERROR: do not use C99

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c r8192U_wx.c fix checkpatch.pl errors and warnings

Hey DaeSeok, I fixed all of them except - this if condition like below: if (5 == wrqu-encoding.length || 13 == wrqu-encoding.length) mask = 0x00; and this should be outside for loop Can you please elaborate on this? Thanks, Chaitanya On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c r8192U_wx.c fix checkpatch.pl errors and warnings

Hi, 2014-05-28 5:28 GMT+09:00 Chaitanya Hazarey c...@24.io: Hey DaeSeok, I fixed all of them except - this if condition like below: if (5 == wrqu-encoding.length || 13 == wrqu-encoding.length) mask = 0x00; and this should be outside for loop Can you please elaborate on this?

[PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Fixed the following: ERROR: do not use C99 // comments ERROR: else should follow close brace '}' ERROR: need consistent spacing around '*' (ctx:WxV) ERROR: need consistent spacing around '|' (ctx:VxW) ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that '--'

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Please ignore this. Chaitanya On Mon, May 26, 2014 at 10:32 PM, Chaitanya Hazarey wrote: > Fixed the following: > > WARNING: line over 80 characters > ERROR: do not use C99 // comments > ERROR: else should follow close brace '}' > ERROR: space required after that ',' (ctx:VxV) > ERROR: space

[PATCH] Staging: rtl8192u: r8180_93cx6.c & r8192U_wx.c fix checkpatch.pl errors and warnings

Fixed the following: WARNING: line over 80 characters ERROR: do not use C99 // comments ERROR: else should follow close brace '}' ERROR: space required after that ',' (ctx:VxV) ERROR: space required after that ';' (ctx:VxV) WARNING: missing space after struct definition ERROR: space required

[PATCH] Staging: rtl8192u: r8180_93cx6.c r8192U_wx.c fix checkpatch.pl errors and warnings

Fixed the following: WARNING: line over 80 characters ERROR: do not use C99 // comments ERROR: else should follow close brace '}' ERROR: space required after that ',' (ctx:VxV) ERROR: space required after that ';' (ctx:VxV) WARNING: missing space after struct definition ERROR: space required

Re: [PATCH] Staging: rtl8192u: r8180_93cx6.c r8192U_wx.c fix checkpatch.pl errors and warnings

Please ignore this. Chaitanya On Mon, May 26, 2014 at 10:32 PM, Chaitanya Hazarey c...@24.io wrote: Fixed the following: WARNING: line over 80 characters ERROR: do not use C99 // comments ERROR: else should follow close brace '}' ERROR: space required after that ',' (ctx:VxV) ERROR: space

[PATCH] Staging: rtl8192u: r8180_93cx6.c r8192U_wx.c fix checkpatch.pl errors and warnings

Fixed the following: ERROR: do not use C99 // comments ERROR: else should follow close brace '}' ERROR: need consistent spacing around '*' (ctx:WxV) ERROR: need consistent spacing around '|' (ctx:VxW) ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that '--'