Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Wed, Sep 30, 2015 at 12:34:33PM +0300, Dan Carpenter wrote: > On Tue, Sep 29, 2015 at 10:24:59PM +0200, Tillmann Heidsieck wrote: > > On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > > > The primary requirement for moving a driver out of staging is that it use > > > mac80211. No

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Wed, Sep 30, 2015 at 12:34:33PM +0300, Dan Carpenter wrote: > On Tue, Sep 29, 2015 at 10:24:59PM +0200, Tillmann Heidsieck wrote: > > On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > > > The primary requirement for moving a driver out of staging is that it use > > > mac80211. No

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Tue, Sep 29, 2015 at 10:24:59PM +0200, Tillmann Heidsieck wrote: > On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > > The primary requirement for moving a driver out of staging is that it use > > mac80211. No amount of cosmetic fixing will ever make that change for > > rtl8712u!

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Tue, Sep 29, 2015 at 10:24:59PM +0200, Tillmann Heidsieck wrote: > On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > > The primary requirement for moving a driver out of staging is that it use > > mac80211. No amount of cosmetic fixing will ever make that change for > > rtl8712u!

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > The primary requirement for moving a driver out of staging is that it use > mac80211. No amount of cosmetic fixing will ever make that change for > rtl8712u! As I am pretty sure someone has done something like this before, is there a

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > The primary requirement for moving a driver out of staging is that it use > mac80211. No amount of cosmetic fixing will ever make that change for > rtl8712u! As I am pretty sure someone has done something like this before, is there a

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > On 09/28/2015 06:18 AM, Sudip Mukherjee wrote: > >On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: > >>On 09/26/2015 11:49 AM, Punit Vara wrote: > >>>This patch is to the rtl871x_ioctl_linux.c that fixes up following >

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On 09/28/2015 06:18 AM, Sudip Mukherjee wrote: On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: On 09/26/2015 11:49 AM, Punit Vara wrote: This patch is to the rtl871x_ioctl_linux.c that fixes up following warning reported by checkpatch.pl : - Comparisons should place the constant

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Mon, Sep 28, 2015 at 4:48 PM, Sudip Mukherjee wrote: > On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: >> On 09/26/2015 11:49 AM, Punit Vara wrote: >> >This patch is to the rtl871x_ioctl_linux.c that fixes up following >> >warning reported by checkpatch.pl : >> > >> >-

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: > On 09/26/2015 11:49 AM, Punit Vara wrote: > >This patch is to the rtl871x_ioctl_linux.c that fixes up following > >warning reported by checkpatch.pl : > > > >- Comparisons should place the constant on the right side of the test > > >

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

Don't worry too much. I think your patches are basically fine. I'm a fairly experience kernel dev but I don't know what an N/M patch is... Just don't work on staging/rtl* any more. The rest of staging is fine. regards, dan carpenter -- To unsubscribe from this list: send the line

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On 09/28/2015 06:18 AM, Sudip Mukherjee wrote: On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: On 09/26/2015 11:49 AM, Punit Vara wrote: This patch is to the rtl871x_ioctl_linux.c that fixes up following warning reported by checkpatch.pl : - Comparisons should place the constant

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > On 09/28/2015 06:18 AM, Sudip Mukherjee wrote: > >On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: > >>On 09/26/2015 11:49 AM, Punit Vara wrote: > >>>This patch is to the rtl871x_ioctl_linux.c that fixes up following >

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

Don't worry too much. I think your patches are basically fine. I'm a fairly experience kernel dev but I don't know what an N/M patch is... Just don't work on staging/rtl* any more. The rest of staging is fine. regards, dan carpenter -- To unsubscribe from this list: send the line

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: > On 09/26/2015 11:49 AM, Punit Vara wrote: > >This patch is to the rtl871x_ioctl_linux.c that fixes up following > >warning reported by checkpatch.pl : > > > >- Comparisons should place the constant on the right side of the test > > >

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Mon, Sep 28, 2015 at 4:48 PM, Sudip Mukherjee wrote: > On Sat, Sep 26, 2015 at 12:45:46PM -0500, Larry Finger wrote: >> On 09/26/2015 11:49 AM, Punit Vara wrote: >> >This patch is to the rtl871x_ioctl_linux.c that fixes up following >> >warning reported by

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Saturday, September 26, 2015 11:24:06 PM punit vara wrote: > On Sat, Sep 26, 2015 at 11:15 PM, Larry Finger > wrote: > > On 09/26/2015 11:49 AM, Punit Vara wrote: > >> > >> This patch is to the rtl871x_ioctl_linux.c that fixes up following > >> warning reported by checkpatch.pl : > >> > >> -

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Sat, Sep 26, 2015 at 11:15 PM, Larry Finger wrote: > On 09/26/2015 11:49 AM, Punit Vara wrote: >> >> This patch is to the rtl871x_ioctl_linux.c that fixes up following >> warning reported by checkpatch.pl : >> >> - Comparisons should place the constant on the right side of the test >> >>

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On 09/26/2015 11:49 AM, Punit Vara wrote: This patch is to the rtl871x_ioctl_linux.c that fixes up following warning reported by checkpatch.pl : - Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara This warning is crap. WTF difference does it

[PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

This patch is to the rtl871x_ioctl_linux.c that fixes up following warning reported by checkpatch.pl : - Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 1 file changed, 8

[PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

This patch is to the rtl871x_ioctl_linux.c that fixes up following warning reported by checkpatch.pl : - Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 1

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On 09/26/2015 11:49 AM, Punit Vara wrote: This patch is to the rtl871x_ioctl_linux.c that fixes up following warning reported by checkpatch.pl : - Comparisons should place the constant on the right side of the test Signed-off-by: Punit Vara This warning is crap. WTF

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Sat, Sep 26, 2015 at 11:15 PM, Larry Finger wrote: > On 09/26/2015 11:49 AM, Punit Vara wrote: >> >> This patch is to the rtl871x_ioctl_linux.c that fixes up following >> warning reported by checkpatch.pl : >> >> - Comparisons should place the constant on the right

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

On Saturday, September 26, 2015 11:24:06 PM punit vara wrote: > On Sat, Sep 26, 2015 at 11:15 PM, Larry Finger > wrote: > > On 09/26/2015 11:49 AM, Punit Vara wrote: > >> > >> This patch is to the rtl871x_ioctl_linux.c that fixes up following > >> warning reported by