Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-11 Thread Madhumthia Prabakaran
On Thu, Apr 11, 2019 at 11:13:28AM +0300, Dan Carpenter wrote: > On Wed, Apr 10, 2019 at 02:49:09PM -0500, Madhumthia Prabakaran wrote: > > On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > > > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > > > diff --git

Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-11 Thread Dan Carpenter
On Wed, Apr 10, 2019 at 02:49:09PM -0500, Madhumthia Prabakaran wrote: > On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h > > >

Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-11 Thread Dan Carpenter
On Wed, Apr 10, 2019 at 02:49:09PM -0500, Madhumthia Prabakaran wrote: > On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h > > >

Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-10 Thread Madhumthia Prabakaran
On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h > > b/drivers/staging/rtl8723bs/include/drv_types.h > > index bafb2c30e7fb..b0623c936940 100644 >

Re: [PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-10 Thread Dan Carpenter
On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h > b/drivers/staging/rtl8723bs/include/drv_types.h > index bafb2c30e7fb..b0623c936940 100644 > --- a/drivers/staging/rtl8723bs/include/drv_types.h > +++

[PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

2019-04-09 Thread Madhumitha Prabakaran
Remove typedef in struct sdio_data and make the respective changes in associated files, as the struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 6 ++--