Re: [PATCH] Staging: rtlwifi: Remove unwanted parentheses

2019-04-03 Thread Madhumthia Prabakaran
On Wed, Apr 03, 2019 at 07:21:45PM +0300, Dan Carpenter wrote: > On Wed, Apr 03, 2019 at 07:18:03PM +0300, Dan Carpenter wrote: > > data_bit = (data & BIT(i)) ? 1 : 0; > > I quite like the !! idiom also... > > data_bit = !!(data & BIT(i)); Thanks for reviewing it. >

Re: [PATCH] Staging: rtlwifi: Remove unwanted parentheses

2019-04-03 Thread Dan Carpenter
On Wed, Apr 03, 2019 at 07:18:03PM +0300, Dan Carpenter wrote: > data_bit = (data & BIT(i)) ? 1 : 0; I quite like the !! idiom also... data_bit = !!(data & BIT(i)); regards, dan carpenter

Re: [PATCH] Staging: rtlwifi: Remove unwanted parentheses

2019-04-03 Thread Dan Carpenter
On Wed, Apr 03, 2019 at 11:04:45AM -0500, Madhumitha Prabakaran wrote: > Remove unwanted parentheses around right hand side of an assignment to > make code better and more understandable. > > Issue found by Coccinelle. > > Signed-off-by: Madhumitha Prabakaran > --- >

[PATCH] Staging: rtlwifi: Remove unwanted parentheses

2019-04-03 Thread Madhumitha Prabakaran
Remove unwanted parentheses around right hand side of an assignment to make code better and more understandable. Issue found by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtlwifi/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git