Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-24 Thread Greg Kroah-Hartman
On Mon, Jan 25, 2016 at 01:29:36AM +0100, Samuel Thibault wrote: > Ping? It's in my queue, I couldn't do anything until after 4.5-rc1 is out. Yours is one of 2000+ other patches I will be digging through this week... thanks, greg k-h

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-24 Thread Samuel Thibault
Ping? Samuel Thibault, on Fri 15 Jan 2016 00:47:41 +0100, wrote: > Commit f79b0d9c223c ("staging: speakup: Fixed warning > instead of ") broke the port information in the speakup > driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included, > and no other header includes

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-24 Thread Greg Kroah-Hartman
On Mon, Jan 25, 2016 at 01:29:36AM +0100, Samuel Thibault wrote: > Ping? It's in my queue, I couldn't do anything until after 4.5-rc1 is out. Yours is one of 2000+ other patches I will be digging through this week... thanks, greg k-h

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-24 Thread Samuel Thibault
Ping? Samuel Thibault, on Fri 15 Jan 2016 00:47:41 +0100, wrote: > Commit f79b0d9c223c ("staging: speakup: Fixed warning > instead of ") broke the port information in the speakup > driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included, > and no other header includes

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-05 Thread Dan Carpenter
On Tue, Jan 05, 2016 at 02:19:12AM +0100, Samuel Thibault wrote: > --- a/drivers/staging/speakup/serialio.c > +++ b/drivers/staging/speakup/serialio.c > @@ -6,6 +6,9 @@ > #include "spk_priv.h" > #include "serialio.h" > > +#include > +#include > + I'm sorry to do this but can you add a

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-05 Thread Dan Carpenter
On Tue, Jan 05, 2016 at 02:19:12AM +0100, Samuel Thibault wrote: > --- a/drivers/staging/speakup/serialio.c > +++ b/drivers/staging/speakup/serialio.c > @@ -6,6 +6,9 @@ > #include "spk_priv.h" > #include "serialio.h" > > +#include > +#include > + I'm sorry to do this but can you add a

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Samuel Thibault
Mmm, sorry. I don't submit patches often enough, so that each time I do it, there are new things to know about it :) Thanks for the comments, Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Samuel Thibault
Patch f79b0d9c223c ("staging: speakup: Fixed warning instead of ") broke the port information in the speakup driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included, and no other header includes asm/serial.h. We here make sure serialio.c does get the arch-specific definition of

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Dan Carpenter
On Mon, Jan 04, 2016 at 03:22:49PM +0300, Dan Carpenter wrote: > On Sun, Jan 03, 2016 at 01:56:20AM +0100, Samuel Thibault wrote: > > cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > > I had a patch which also worked, but yours may be better -- I enclose it > > > here for your

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Dan Carpenter
On Sun, Jan 03, 2016 at 01:56:20AM +0100, Samuel Thibault wrote: > cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > I had a patch which also worked, but yours may be better -- I enclose it > > here for your information. > > Well, it's not up to serialio.h to include things for

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Dan Carpenter
On Sun, Jan 03, 2016 at 12:25:29AM +0100, Samuel Thibault wrote: > 5e6dc54 broke the port information in the speakup driver: There is a correct format for this. Patch 5e6dc548e453 ('drivers: staging: speakup: serialio: only use platform specific SERIAL_PORT_DFNS.') broke the port information ...

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Samuel Thibault
Mmm, sorry. I don't submit patches often enough, so that each time I do it, there are new things to know about it :) Thanks for the comments, Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Samuel Thibault
Patch f79b0d9c223c ("staging: speakup: Fixed warning instead of ") broke the port information in the speakup driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included, and no other header includes asm/serial.h. We here make sure serialio.c does get the arch-specific definition of

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Dan Carpenter
On Sun, Jan 03, 2016 at 12:25:29AM +0100, Samuel Thibault wrote: > 5e6dc54 broke the port information in the speakup driver: There is a correct format for this. Patch 5e6dc548e453 ('drivers: staging: speakup: serialio: only use platform specific SERIAL_PORT_DFNS.') broke the port information ...

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Dan Carpenter
On Sun, Jan 03, 2016 at 01:56:20AM +0100, Samuel Thibault wrote: > cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > I had a patch which also worked, but yours may be better -- I enclose it > > here for your information. > > Well, it's not up to serialio.h to include things for

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-04 Thread Dan Carpenter
On Mon, Jan 04, 2016 at 03:22:49PM +0300, Dan Carpenter wrote: > On Sun, Jan 03, 2016 at 01:56:20AM +0100, Samuel Thibault wrote: > > cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > > I had a patch which also worked, but yours may be better -- I enclose it > > > here for your

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread covici
Well, OK with me, I will use yours instead because I don't know if they will backport the thing, thanks so much for doing this. Samuel Thibault wrote: > cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > I had a patch which also worked, but yours may be better -- I enclose it

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread Samuel Thibault
cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > I had a patch which also worked, but yours may be better -- I enclose it > here for your information. Well, it's not up to serialio.h to include things for serialio.c. That however makes me realize that the culprit is actually

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread covici
I had a patch which also worked, but yours may be better -- I enclose it here for your information. --- drivers/staging/speakup/serialio.h.old 2015-08-30 14:34:09.0 -0400 +++ drivers/staging/speakup/serialio.h 2015-10-07 06:27:04.880829874 -0400 @@ -1,22 +1,24 @@ #ifndef

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread Samuel Thibault
Samuel Thibault, on Sun 03 Jan 2016 00:25:29 +0100, wrote: > 5e6dc54 broke the port information in the speakup driver: > SERIAL_PORT_DFNS only gets defined if asm/serial.h is included. > > Along the way, make sure that we do have information for the requested > serial port number (index) (It'd

[PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread Samuel Thibault
5e6dc54 broke the port information in the speakup driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included. Along the way, make sure that we do have information for the requested serial port number (index) Signed-off-by: Samuel Thibault --- a/drivers/staging/speakup/serialio.c

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread covici
I had a patch which also worked, but yours may be better -- I enclose it here for your information. --- drivers/staging/speakup/serialio.h.old 2015-08-30 14:34:09.0 -0400 +++ drivers/staging/speakup/serialio.h 2015-10-07 06:27:04.880829874 -0400 @@ -1,22 +1,24 @@ #ifndef

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread Samuel Thibault
Samuel Thibault, on Sun 03 Jan 2016 00:25:29 +0100, wrote: > 5e6dc54 broke the port information in the speakup driver: > SERIAL_PORT_DFNS only gets defined if asm/serial.h is included. > > Along the way, make sure that we do have information for the requested > serial port number (index) (It'd

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread Samuel Thibault
cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > I had a patch which also worked, but yours may be better -- I enclose it > here for your information. Well, it's not up to serialio.h to include things for serialio.c. That however makes me realize that the culprit is actually

[PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread Samuel Thibault
5e6dc54 broke the port information in the speakup driver: SERIAL_PORT_DFNS only gets defined if asm/serial.h is included. Along the way, make sure that we do have information for the requested serial port number (index) Signed-off-by: Samuel Thibault ---

Re: [PATCH] Staging: speakup: Fix getting port information

2016-01-02 Thread covici
Well, OK with me, I will use yours instead because I don't know if they will backport the thing, thanks so much for doing this. Samuel Thibault wrote: > cov...@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote: > > I had a patch which also worked, but yours