Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-25 Thread Greg KH
On Sat, Jan 17, 2015 at 07:11:18PM -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr > comment is implied by the first argument being the channel. No parent bus > comment is already understood by the argument being NULL. > >

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-25 Thread Greg KH
On Sat, Jan 17, 2015 at 07:11:18PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by:

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
On Sat, Jan 17, 2015 at 08:01:52PM -0800, Joe Perches wrote: > On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. > > which ones? > > As far as I can tell, none of the checkpatch > warnings on this file are actually addressed > by this

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Joe Perches
On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. which ones? As far as I can tell, none of the checkpatch warnings on this file are actually addressed by this patch. -- To unsubscribe from this list: send the line "unsubscribe

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich --- drivers/staging/unisys/virtpci/virtpci.c | 24

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich --- drivers/staging/unisys/virtpci/virtpci.c | 24

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 07:01:41PM -0800, Andrew Milkovich wrote: > Hi, > > On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > > chanptr > >

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Hi again, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > chanptr > > comment is implied by the first argument being the channel. No parent

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Hi, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: > On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed; > > chanptr > > comment is implied by the first argument being the channel. No parent bus > >

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Greg KH
On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr > comment is implied by the first argument being the channel. No parent bus > comment is already understood by the argument being NULL. > >

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Hi, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 07:01:41PM -0800, Andrew Milkovich wrote: Hi, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich amilkov...@gmail.com ---

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Joe Perches
On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. which ones? As far as I can tell, none of the checkpatch warnings on this file are actually addressed by this patch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich amilkov...@gmail.com ---

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Greg KH
On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by:

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
On Sat, Jan 17, 2015 at 08:01:52PM -0800, Joe Perches wrote: On Sat, 2015-01-17 at 19:30 -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. which ones? As far as I can tell, none of the checkpatch warnings on this file are actually addressed by this patch.

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-17 Thread Andrew Milkovich
Hi again, On Sat, Jan 17, 2015 at 04:22:35PM -0800, Greg KH wrote: On Fri, Jan 16, 2015 at 08:58:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-16 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich --- drivers/staging/unisys/virtpci/virtpci.c | 24

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-16 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed; chanptr comment is implied by the first argument being the channel. No parent bus comment is already understood by the argument being NULL. Signed-off-by: Andrew Milkovich amilkov...@gmail.com ---

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-12 Thread Greg KH
On Mon, Jan 12, 2015 at 02:53:53PM -0800, Andrew Milkovich wrote: > Hi, > > On Fri, Jan 09, 2015 at 05:41:23PM -0800, Greg KH wrote: > > On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: > > > Fixed coding style errors per checkpatch.pl. Inline comments removed. > > > > What

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-12 Thread Andrew Milkovich
Hi, On Fri, Jan 09, 2015 at 05:41:23PM -0800, Greg KH wrote: > On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: > > Fixed coding style errors per checkpatch.pl. Inline comments removed. > > What coding errors did you fix? Please be specific. Some inline comments were removed.

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-12 Thread Andrew Milkovich
Hi, On Fri, Jan 09, 2015 at 05:41:23PM -0800, Greg KH wrote: On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed. What coding errors did you fix? Please be specific. Some inline comments were removed. Some

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-12 Thread Greg KH
On Mon, Jan 12, 2015 at 02:53:53PM -0800, Andrew Milkovich wrote: Hi, On Fri, Jan 09, 2015 at 05:41:23PM -0800, Greg KH wrote: On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed. What coding errors

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-09 Thread Greg KH
On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: > Fixed coding style errors per checkpatch.pl. Inline comments removed. What coding errors did you fix? Please be specific. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors

2015-01-09 Thread Greg KH
On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote: Fixed coding style errors per checkpatch.pl. Inline comments removed. What coding errors did you fix? Please be specific. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2014-12-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed. Signed-off-by: Andrew Milkovich --- drivers/staging/unisys/virtpci/virtpci.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/staging/unisys/virtpci/virtpci.c

[PATCH] Staging: unisys: virtpci: fixed coding style errors

2014-12-17 Thread Andrew Milkovich
Fixed coding style errors per checkpatch.pl. Inline comments removed. Signed-off-by: Andrew Milkovich amilkov...@gmail.com --- drivers/staging/unisys/virtpci/virtpci.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git