Re: [PATCH] Staging : wilc1000: Remove unnecessary parentheses

2015-07-29 Thread Dan Carpenter
The original code is fine... I probably would write it the way you suggest, but I can also see why people would write it the other way. This isn't an official CodingStyle rule so I feel like the author gets to choose. Part of the reason for CodingStyle is so that we don't run into madness of

Re: [PATCH] Staging : wilc1000: Remove unnecessary parentheses

2015-07-29 Thread Dan Carpenter
The original code is fine... I probably would write it the way you suggest, but I can also see why people would write it the other way. This isn't an official CodingStyle rule so I feel like the author gets to choose. Part of the reason for CodingStyle is so that we don't run into madness of

[PATCH] Staging : wilc1000: Remove unnecessary parentheses

2015-07-28 Thread Shraddha Barke
Remove parentheses around the right hand side of an assignment as they are not needed The semantic patch used is : @@ expression E; expression f; constant C; @@ ( f = (E == C) | f = - ( E - ) ) Signed-off-by: Shraddha Barke --- drivers/staging/wilc1000/wilc_sdio.c | 2 +- 1 file changed, 1

[PATCH] Staging : wilc1000: Remove unnecessary parentheses

2015-07-28 Thread Shraddha Barke
Remove parentheses around the right hand side of an assignment as they are not needed The semantic patch used is : @@ expression E; expression f; constant C; @@ ( f = (E == C) | f = - ( E - ) ) Signed-off-by: Shraddha Barke shraddha.6...@gmail.com --- drivers/staging/wilc1000/wilc_sdio.c |