On Friday 15 June 2007 00:15, Dmitry Torokhov wrote:
> How about the patch below instead?
>
And one more time without warnings...
--
Dmitry
Subject: Input: xpad - add support for leds on xbox 360 pad
From: Jan Kratochvil <[EMAIL PROTECTED]>
Input: xpad - add support for leds on xbox 360 pad
Hi Jan,
On Sunday 03 June 2007 14:02, Jan Kratochvil wrote:
> + list_for_each_entry(pos_led, &xpad_led_list, node) {
> + if (pos_led->id == i)
> + i++;
> + else
> + break;
> + }
I don't like this list business, it
Hi,
the previous patch made led support dependent on force feedback. Which
doesn't make sense from user point of view. So this patch removes this odd
dependency. I made it in separate patch to make my changes easier to
review.
Led support of xbox 360 now doesn't depend on force feedback.
Si
On Wed, 30 May 2007, Jan Kratochvil wrote:
Hi,
In ideal world having the code in drivers/leds would be preferred but if
you want to add the LED code directly to the input driver in this case I
have no objection and it probably makes sense. The LED code is already
spread about a bit anyway...
I
Hi,
On Thu, 2007-05-31 at 17:53 +0200, Jan Kratochvil wrote:
> On Thu, 31 May 2007, Pavel Machek wrote:
> >> Led subsystem allows us to set brightness, but there is
> >> nothing like brightness on this device. So brightness is
> >> actually interpreted as the command (only values between
> >> 0 an
Hi,
On Thu, 31 May 2007, Pavel Machek wrote:
Led subsystem allows us to set brightness, but there is
nothing like brightness on this device. So brightness is
actually interpreted as the command (only values between
0 and 14 are accepted).
Ugh, no, I do not think we want to do that.
finally!
Hi!
> this patch is against current input tree.
>
> Xbox360 pad has four leds, which forms a circle.
> Unfortunately the leds itself are not independent, and
> we can't control them directle, but rather through
> sending commands which have predefined meaning (like
> turn first on, others of
Hi,
On Wed, 30 May 2007, Richard Purdie wrote:
On Wed, 2007-05-30 at 10:56 -0400, Dmitry Torokhov wrote:
Do you think it makes sense to split the driver (and Kconfig options)
between input and leds directories as Jan had done? I know that I
prefer to keep anything input related in input directo
Hi Dmitry,
On Wed, 2007-05-30 at 10:56 -0400, Dmitry Torokhov wrote:
> Do you think it makes sense to split the driver (and Kconfig options)
> between input and leds directories as Jan had done? I know that I
> prefer to keep anything input related in input directory because it
> makes my life as
On 5/29/07, Richard Purdie <[EMAIL PROTECTED]> wrote:
On Tue, 2007-05-29 at 23:29 +0200, Jan Kratochvil wrote:
>
> I have the impression that the led subsystem doesn't actually count with
> possibility to have more then one device of one type, right? In my case there
> can by lots of pads, so I m
On Tuesday 29 May 2007 17:41, Richard Purdie wrote:
> On Tue, 2007-05-29 at 23:29 +0200, Jan Kratochvil wrote:
> > I have question, probably for Richard. Why is
> > /sys/class/leds/whatsoever/brightness mode set to 0644? Is it really
> > necessary?
> > I feel like I'll be happy to allow anybod
On Tue, 2007-05-29 at 23:29 +0200, Jan Kratochvil wrote:
>I have question, probably for Richard. Why is
> /sys/class/leds/whatsoever/brightness mode set to 0644? Is it really
> necessary?
> I feel like I'll be happy to allow anybody to change the state of this led.
> (Ok
> this maybe doesn'
Hello,
I have question, probably for Richard. Why is
/sys/class/leds/whatsoever/brightness mode set to 0644? Is it really necessary?
I feel like I'll be happy to allow anybody to change the state of this led. (Ok
this maybe doesn't apply to other leds)
So this patch uses led subystem in suc
Hello,
this patch is against current input tree.
Xbox360 pad has four leds, which forms a circle. Unfortunately the leds itself
are not independent, and we can't control them directle, but rather through
sending commands which have predefined meaning (like turn first on, others off)
This patch
14 matches
Mail list logo
